cs_disasm_iter: return early on zero-size input#2886
Merged
Rot127 merged 1 commit intocapstone-engine:nextfrom Mar 28, 2026
Merged
cs_disasm_iter: return early on zero-size input#2886Rot127 merged 1 commit intocapstone-engine:nextfrom
Rot127 merged 1 commit intocapstone-engine:nextfrom
Conversation
Prevent calling backend decoder with no remaining bytes, which could lead to out-of-bounds reads.
Rot127
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
cs_disasm_iter() does not stop when size reaches zero, allowing the backend decoder to be called with no remaining input. This results in out-of-bounds reads, observed in the RISC-V unit test introduced in #2881 under ASan.
Test plan
...
Closing issues
...