RFC/WIP: Introduce capnp-json for JSON code compatible with c++ default capnproto implementation#600
Open
puremourning wants to merge 35 commits intocapnproto:masterfrom
Open
RFC/WIP: Introduce capnp-json for JSON code compatible with c++ default capnproto implementation#600puremourning wants to merge 35 commits intocapnproto:masterfrom
puremourning wants to merge 35 commits intocapnproto:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 51.64% 51.51% -0.13%
==========================================
Files 69 77 +8
Lines 33735 35258 +1523
==========================================
+ Hits 17422 18163 +741
- Misses 16313 17095 +782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
190c1f6 to
a3d6558
Compare
puremourning
commented
Dec 29, 2025
| field_meta.name | ||
| ))); | ||
| }; | ||
| Ok((*field_value as i8).into()) |
Author
There was a problem hiding this comment.
Handle encoded values > 127 correctly.
ditto for the other types, we should fail, rather than panic.
puremourning
commented
Dec 29, 2025
| JsonValue::String(field_value) => { | ||
| let enum_schema = capnp::schema::EnumSchema::new(enum_schema); | ||
| let Some(enum_value) = enum_schema.get_enumerants()?.iter().find(|e| { | ||
| // FIXME: this is naive, enum values can be renamed using |
Author
There was a problem hiding this comment.
Remove comment, it's handled
We simply write synchronously to a std::io::Write. The codec supports all types that the C++ codec supports, along with the flatten, hex and base64 annotations. It does not support discriminated unions yet. It supports only encode, no decode. It's not fast, efficient, or especially good.
…t schema from c++ repo
…bility with the c++ implementation... and fix the resulting bugs found
…rs with a discriminator
2cea57f to
de66bbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #68, I'm sharing this very rough cut of JSON codec support for input.
Some assumptions I made, which influenced the implementation, but could be changed depending on your view:
What's supported:
flatten,discriminator,namebase64,hexandarray of numbersencodings forDatafields.The best doc on the actual encoding is the json.capnp which is taken directly from upstream. We don't use all of it, but I kept it unmodified anyway.
What's not supported, and what deviates from the upstream implementation: