feat: support for App Open Ad en Android e iOS by BETOXL · Pull Request #386 · capacitor-community/admob

BETOXL · 2025-10-11T02:17:34Z

Adds native and TypeScript support for the Open Ad App format on Android and iOS.
Includes usage examples in the Angular demo.
Documentation and exposed events.

Copilot

Pull Request Overview

This PR adds support for App Open Ad format on both Android and iOS platforms, integrating it into the AdMob plugin with complete TypeScript definitions and usage examples.

Adds App Open Ad functionality with load, show, and status check methods
Implements native iOS and Android code using Google Mobile Ads SDK
Includes TypeScript definitions, events, and Angular demo integration

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/web.ts	Adds stub methods for App Open Ad functionality in web implementation
src/index.ts	Exports new App Open Ad module
src/definitions.ts	Integrates App Open Ad plugin interface into main plugin definitions
src/app-open/*	Complete TypeScript definitions for App Open Ad functionality including options, events, and plugin interface
ios/Sources/AdMobPlugin/*	Native iOS implementation using GADAppOpenAd with manager pattern
android/src/main/java/*	Native Android implementation using Google Mobile Ads AppOpenAd API
demo/angular/src/app/app.component.ts	Angular demo showing App Open Ad usage with event listeners
README.md	Documentation for App Open Ad API methods and usage examples

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/web.ts

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

demo/angular/src/app/app.component.ts

README.md

distante

Hello @BETOXL ! thanks for your PR, please check the comments and the CI. You probably need to run the formatter. (I will try to add it to the pre commit lint in the future)

Also can you please update the tests to include your changes?

Thank you!

package-lock.json

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

demo/angular/src/app/app.component.ts

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

src/app-open/app-open-definitions.interface.ts

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

src/web.ts

distante · 2025-10-11T09:17:01Z

README.md

+} from '@capacitor-community/admob';
+
+export async function showAppOpenAd(): Promise<void> {
+  // Escuchar eventos


Comments in English.

Co-authored-by: Copilot <[email protected]>

distante · 2025-10-14T10:01:07Z

a lot of comments are not correctly resolved.

distante

Please do not resolve comments without fixing them.

no single line ifs please

this should be inside the AdMob class.

comments in English.

no single line ifs please

comments in English

Replace any type with proper AppOpenAdOptions type for better type safety and API consistency.

distante

The CI is still failing.

You should check how the other implementation is done so you can fix and add your tests.

src/web.ts

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

Moved AppOpenAd Plugin initialization inside the AdMob class.

delete comment

BETOXL

delete comment

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

src/app-open/app-open-definitions.interface.ts

src/web.ts

test appOpen

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 17 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdPlugin.java

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

README.md

demo/angular/src/app/app.component.ts

src/web.ts

android/src/test/java/com/getcapacitor/community/admob/models/AdOptionsTest.java

README.md

demo/angular/src/app/app.component.ts

…/AppOpenAdPlugin.java Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]>

Facevedo74 · 2026-02-13T15:59:12Z

Good morning, what became of this feat?

BETOXL

changes

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T07:10:58Z

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

+    private final AppOpenAdPlugin appOpenAdPlugin = new AppOpenAdPlugin();
+
+    @PluginMethod
+    public void loadAppOpen(final PluginCall call) {
+        appOpenAdPlugin.loadAppOpen(call);
+    }
+
+    @PluginMethod
+    public void showAppOpen(final PluginCall call) {
+        appOpenAdPlugin.showAppOpen(call);
+    }
+
+    @PluginMethod
+    public void isAppOpenLoaded(final PluginCall call) {


AppOpenAdPlugin extends Capacitor Plugin, but AdMob instantiates it directly (new AppOpenAdPlugin()) and forwards calls. Plugin instances need to be created/attached by Capacitor to have a valid bridge/context/activity; this setup risks getContext()/getActivity() being null and listeners not working. Refactor App Open into an executor/helper (like other ad executors) that uses AdMob's getContext/getActivity/notifyListeners, or implement the logic directly in AdMob.

Suggested change

private final AppOpenAdPlugin appOpenAdPlugin = new AppOpenAdPlugin();

@PluginMethod

public void loadAppOpen(final PluginCall call) {

appOpenAdPlugin.loadAppOpen(call);

}

@PluginMethod

public void showAppOpen(final PluginCall call) {

appOpenAdPlugin.showAppOpen(call);

}

@PluginMethod

public void isAppOpenLoaded(final PluginCall call) {

private AppOpenAdPlugin getAppOpenAdPlugin() {

if (getBridge() == null) {

return null;

}

try {

Plugin plugin = getBridge().getPlugin("AppOpenAdPlugin");

if (plugin instanceof AppOpenAdPlugin) {

return (AppOpenAdPlugin) plugin;

}

} catch (Exception ignored) {

// If the plugin cannot be obtained, return null and let callers handle it.

}

return null;

}

@PluginMethod

public void loadAppOpen(final PluginCall call) {

AppOpenAdPlugin appOpenAdPlugin = getAppOpenAdPlugin();

if (appOpenAdPlugin == null) {

call.reject("AppOpenAdPlugin is not available");

return;

}

appOpenAdPlugin.loadAppOpen(call);

}

@PluginMethod

public void showAppOpen(final PluginCall call) {

AppOpenAdPlugin appOpenAdPlugin = getAppOpenAdPlugin();

if (appOpenAdPlugin == null) {

call.reject("AppOpenAdPlugin is not available");

return;

}

appOpenAdPlugin.showAppOpen(call);

}

@PluginMethod

public void isAppOpenLoaded(final PluginCall call) {

AppOpenAdPlugin appOpenAdPlugin = getAppOpenAdPlugin();

if (appOpenAdPlugin == null) {

call.reject("AppOpenAdPlugin is not available");

return;

}

Copilot · 2026-03-06T07:10:58Z

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdPlugin.java

+        appOpenAdManager.loadAd(context, () -> {
+            notifyListeners("appOpenAdLoaded", new JSONObject());
+            call.resolve();
+        }, () -> {
+            notifyListeners("appOpenAdFailedToLoad", new JSONObject());
+            call.reject("Failed to load App Open Ad");
+        });


notifyListeners expects a JSObject, but this code passes org.json.JSONObject, which is inconsistent with the rest of the plugin and may not compile. Use com.getcapacitor.JSObject (or pass null/an empty JSObject) for event payloads.

Copilot · 2026-03-06T07:10:59Z

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdPlugin.java

+    @PluginMethod
+    public void showAppOpen(PluginCall call) {
+        Activity activity = getActivity();
+        appOpenAdManager.showAdIfAvailable(activity, () -> {
+            notifyListeners("appOpenAdClosed", new JSONObject());
+            call.resolve();
+        }, () -> {
+            notifyListeners("appOpenAdFailedToShow", new JSONObject());
+            call.reject("Failed to show App Open Ad");
+        });
+    }


showAppOpen assumes appOpenAdManager and activity are non-null; if loadAppOpen was never called or the plugin isn't attached, this can crash or hang. Add null checks and call.reject(...) when there's no loaded manager/ad or no current activity.

Copilot · 2026-03-06T07:10:59Z

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

+        if (isLoadingAd || appOpenAd != null) {
+            return;
+        }
+


loadAd returns early when already loading or already loaded without invoking callbacks. Since the plugin call resolves/rejects only inside those callbacks, the JS promise can remain pending forever. Return a status and resolve immediately (already loaded/loading) or invoke onLoaded when appOpenAd != null.

Suggested change

if (isLoadingAd || appOpenAd != null) {

return;

}

if (appOpenAd != null) {

if (onLoaded != null) {

onLoaded.run();

}

return;

}

if (isLoadingAd) {

if (onFailed != null) {

onFailed.run();

}

return;

}

Copilot · 2026-03-06T07:10:59Z

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

+        isShowingAd = true;
+        appOpenAd.setFullScreenContentCallback(new FullScreenContentCallback() {
+            @Override
+            public void onAdDismissedFullScreenContent() {
+                appOpenAd = null;
+                isShowingAd = false;
+
+                if (onClosed != null) {
+                    onClosed.run();
+                }
+            }
+
+            @Override
+            public void onAdFailedToShowFullScreenContent(com.google.android.gms.ads.AdError adError) {
+                appOpenAd = null;
+                isShowingAd = false;
+
+                if (onFailedToShow != null) {
+                    onFailedToShow.run();
+                }
+            }
+        });


AppOpenAdPluginEvents.Opened is defined/used, but Android never notifies an "opened" event. Consider triggering it from FullScreenContentCallback.onAdShowedFullScreenContent() so JS listeners behave consistently with the documented API.

Copilot · 2026-03-06T07:11:00Z

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

+        if isLoadingAd || appOpenAd != nil {
+            return
+        }
+


loadAd returns early when an ad is already loaded or loading, but it doesn't invoke onLoaded/onFailed. Because the plugin call waits on these callbacks, this can leave the JS promise pending forever. Return a status (already loaded/loading) and resolve/reject accordingly, or invoke onLoaded when appOpenAd != nil.

Suggested change

if isLoadingAd || appOpenAd != nil {

return

}

// If an ad is already loaded, report success immediately.

if appOpenAd != nil {

onLoaded()

return

}

// If an ad is currently loading, report failure to avoid leaving callers hanging.

if isLoadingAd {

onFailed()

return

}

Copilot · 2026-03-06T07:11:00Z

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

+        isShowingAd = true
+        ad.fullScreenContentDelegate = self
+        ad.present(fromRootViewController: rootViewController)
+        self.onClosed = onClosed
+        self.onFailedToShow = onFailedToShow


In showAdIfAvailable, onClosed/onFailedToShow are stored after calling present. Delegate callbacks can fire immediately, so the closures may still be nil and the JS call may never resolve/reject. Assign the closures before presenting the ad.

Suggested change

isShowingAd = true

ad.fullScreenContentDelegate = self

ad.present(fromRootViewController: rootViewController)

self.onClosed = onClosed

self.onFailedToShow = onFailedToShow

self.onClosed = onClosed

self.onFailedToShow = onFailedToShow

isShowingAd = true

ad.fullScreenContentDelegate = self

ad.present(fromRootViewController: rootViewController)

Copilot · 2026-03-06T07:11:00Z

README.md

+    console.log('Failed to load App Open Ad');
+  });

+  const options: AppOpenAdOptions = {
+    adUnitId: 'TU_AD_UNIT_ID',
+    showOnColdStart: true, // Opcional
+    showOnForeground: true, // Opcional


The FailedToShow listener logs "Failed to load App Open Ad" and the comments use "Opcional"/TU_AD_UNIT_ID, which is inconsistent with the surrounding English docs. Consider updating to "Failed to show...", "Optional", and an English placeholder like YOUR_AD_UNIT_ID for clarity.

Suggested change

console.log('Failed to load App Open Ad');

});

const options: AppOpenAdOptions = {

adUnitId: 'TU_AD_UNIT_ID',

showOnColdStart: true, // Opcional

showOnForeground: true, // Opcional

console.log('Failed to show App Open Ad');

});

const options: AppOpenAdOptions = {

adUnitId: 'YOUR_AD_UNIT_ID',

showOnColdStart: true, // Optional

showOnForeground: true, // Optional

Copilot · 2026-03-06T07:11:00Z

src/app-open/app-open-ad-options.interface.ts

+  showOnColdStart?: boolean;
+  showOnForeground?: boolean;


showOnColdStart / showOnForeground are defined in the public options but are not used anywhere in the repo (native or TS). This makes the API misleading; either implement the behavior (hook into app lifecycle) or remove these fields until supported.

Suggested change

showOnColdStart?: boolean;

showOnForeground?: boolean;

Copilot · 2026-03-06T07:11:01Z

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdPlugin.swift

+    @objc func showAppOpen(_ call: CAPPluginCall) {
+        DispatchQueue.main.async {
+            if let rootVC = UIApplication.shared.keyWindow?.rootViewController {
+                self.appOpenAdManager?.showAdIfAvailable(rootViewController: rootVC, onClosed: {
+                    self.notifyListeners("appOpenAdClosed", data: [:])
+                    call.resolve()
+                }, onFailedToShow: {
+                    self.notifyListeners("appOpenAdFailedToShow", data: [:])
+                    call.reject("Failed to show App Open Ad")
+                })


showAppOpen never emits the appOpenAdOpened event even though it’s exposed in AppOpenAdPluginEvents and used in the demo/docs. Consider emitting an "Opened" event when presentation begins (e.g., via GADFullScreenContentDelegate.adDidPresentFullScreenContent or a callback from AppOpenAdManager).

distante

Please check the copilot comments.

I will try to check this this week(end) so we can get this merged

distante · 2026-03-06T07:04:38Z

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

-     * @see <a href="https://developers.google.com/admob/android/targeting">Target Settings</a>
-     */
+    // ---------------------------------------------------------
+    // REQUEST CONFIGURATION


please keep the documentation link for future developers

distante · 2026-03-06T09:01:29Z

Also check the CI errors.

Note: Closes #167

feat: soporte para App Open Ad en Android e iOS

e3c2d24

distante requested a review from Copilot October 11, 2025 09:03

Copilot AI reviewed Oct 11, 2025

View reviewed changes

distante requested changes Oct 11, 2025

View reviewed changes

BETOXL and others added 5 commits October 13, 2025 12:00

Update src/web.ts

ded6452

Co-authored-by: Copilot <[email protected]>

Update src/web.ts

d1bbba1

Co-authored-by: Copilot <[email protected]>

Update demo/angular/src/app/app.component.ts

9494d2e

Co-authored-by: Copilot <[email protected]>

Update README.md

e65274f

Co-authored-by: Copilot <[email protected]>

Merge branch 'master' into feat/app-open-ad

8d6d787

BETOXL requested a review from distante October 13, 2025 21:53

distante requested changes Oct 14, 2025

View reviewed changes

BETOXL added 11 commits October 14, 2025 12:09

Update README.md

a1d73cf

Update README.md

2549a0a

Update AppOpenAdManager.java

8f33ad7

Update AppOpenAdManager.java

4aac09b

Update AppOpenAdManager.java

23ab476

no single line ifs please

Update AdMob.java

eee34de

this should be inside the AdMob class.

Update app.component.ts

5359b16

comments in English.

Update AppOpenAdManager.swift

3548d4f

no single line ifs please

Update app-open-definitions.interface.ts

a00d292

comments in English

Update web.ts

f81c2d6

Replace any type with proper AppOpenAdOptions type for better type safety and API consistency.

Update README.md

a0eae03

distante reviewed Oct 15, 2025

View reviewed changes

src/web.ts Outdated Show resolved Hide resolved

android/src/main/java/com/getcapacitor/community/admob/AdMob.java Outdated Show resolved Hide resolved

BETOXL added 2 commits October 25, 2025 16:43

Refactor AppOpenAd Plugin initialization

b82471b

Moved AppOpenAd Plugin initialization inside the AdMob class.

Define AppOpenAdOptions interface and update loadAppOpen

f742340

delete comment

BETOXL commented Oct 25, 2025

View reviewed changes

BETOXL changed the title ~~feat: soporte para App Open Ad en Android e iOS~~ feat: support for App Open Ad en Android e iOS Oct 25, 2025

BETOXL added 2 commits October 25, 2025 16:53

Merge branch 'main' into feat/app-open-ad

a885fad

Update AppOpenAdManager.java

3b9d047

test appOpen

BETOXL mentioned this pull request Dec 4, 2025

App open ad unit is now needed more then ever #338

Open

distante requested a review from Copilot December 4, 2025 06:55

Copilot started reviewing on behalf of distante December 4, 2025 06:55 View session

Copilot finished reviewing on behalf of distante December 4, 2025 06:59

Copilot AI reviewed Dec 4, 2025

View reviewed changes

BETOXL and others added 7 commits December 4, 2025 10:04

Update android/src/main/java/com/getcapacitor/community/admob/appopen…

5b3f914

…/AppOpenAdPlugin.java Co-authored-by: Copilot <[email protected]>

Update src/web.ts

ed1c654

Co-authored-by: Copilot <[email protected]>

Update README.md

5fcb155

Co-authored-by: Copilot <[email protected]>

Update demo/angular/src/app/app.component.ts

88caf87

Co-authored-by: Copilot <[email protected]>

Update README.md

ef80ce7

Co-authored-by: Copilot <[email protected]>

Update README.md

9d8c31b

Co-authored-by: Copilot <[email protected]>

Update demo/angular/src/app/app.component.ts

7c8c244

Co-authored-by: Copilot <[email protected]>

Merge branch 'main' into feat/app-open-ad

416edc0

BETOXL commented Feb 25, 2026

View reviewed changes

BETOXL marked this pull request as draft February 25, 2026 14:04

BETOXL marked this pull request as ready for review February 25, 2026 14:05

distante requested a review from Copilot March 6, 2026 07:02

Copilot started reviewing on behalf of distante March 6, 2026 07:02 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

distante requested changes Mar 6, 2026

View reviewed changes

-    private final AppOpenAdPlugin appOpenAdPlugin = new AppOpenAdPlugin();
-    @PluginMethod
-    public void loadAppOpen(final PluginCall call) {
-        appOpenAdPlugin.loadAppOpen(call);
-    }
-    @PluginMethod
-    public void showAppOpen(final PluginCall call) {
-        appOpenAdPlugin.showAppOpen(call);
-    }
-    @PluginMethod
-    public void isAppOpenLoaded(final PluginCall call) {
+    private AppOpenAdPlugin getAppOpenAdPlugin() {
+        if (getBridge() == null) {
+            return null;
+        }
+        try {
+            Plugin plugin = getBridge().getPlugin("AppOpenAdPlugin");
+            if (plugin instanceof AppOpenAdPlugin) {
+                return (AppOpenAdPlugin) plugin;
+            }
+        } catch (Exception ignored) {
+            // If the plugin cannot be obtained, return null and let callers handle it.
+        }
+        return null;
+    }
+    @PluginMethod
+    public void loadAppOpen(final PluginCall call) {
+        AppOpenAdPlugin appOpenAdPlugin = getAppOpenAdPlugin();
+        if (appOpenAdPlugin == null) {
+            call.reject("AppOpenAdPlugin is not available");
+            return;
+        }
+        appOpenAdPlugin.loadAppOpen(call);
+    }
+    @PluginMethod
+    public void showAppOpen(final PluginCall call) {
+        AppOpenAdPlugin appOpenAdPlugin = getAppOpenAdPlugin();
+        if (appOpenAdPlugin == null) {
+            call.reject("AppOpenAdPlugin is not available");
+            return;
+        }
+        appOpenAdPlugin.showAppOpen(call);
+    }
+    @PluginMethod
+    public void isAppOpenLoaded(final PluginCall call) {
+        AppOpenAdPlugin appOpenAdPlugin = getAppOpenAdPlugin();
+        if (appOpenAdPlugin == null) {
+            call.reject("AppOpenAdPlugin is not available");
+            return;
+        }

-        if (isLoadingAd || appOpenAd != null) {
-            return;
-        }
+        if (appOpenAd != null) {
+            if (onLoaded != null) {
+                onLoaded.run();
+            }
+            return;
+        }
+        if (isLoadingAd) {
+            if (onFailed != null) {
+                onFailed.run();
+            }
+            return;
+        }

-        if isLoadingAd || appOpenAd != nil {
-            return
-        }
+        // If an ad is already loaded, report success immediately.
+        if appOpenAd != nil {
+            onLoaded()
+            return
+        }
+        // If an ad is currently loading, report failure to avoid leaving callers hanging.
+        if isLoadingAd {
+            onFailed()
+            return
+        }

Conversation

BETOXL commented Oct 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

distante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

distante Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

distante commented Oct 14, 2025

Uh oh!

distante left a comment

Choose a reason for hiding this comment

Uh oh!

distante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BETOXL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Facevedo74 commented Feb 13, 2026

Uh oh!

BETOXL left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

distante commented Mar 6, 2026 •

edited

Loading