fix(scaleway): prevent crash on missing metadata keys (#6602) - #6608
Closed
ffeldhaus wants to merge 2 commits into
Closed
fix(scaleway): prevent crash on missing metadata keys (#6602)#6608ffeldhaus wants to merge 2 commits into
ffeldhaus wants to merge 2 commits into
Conversation
Use safe `.get()` access for `private_ip` and `ipv6` metadata fields to avoid KeyErrors when these optional fields are missing. Additionally: - Ensure `ipv6` is treated as a dictionary and check for existence of required keys (`address`, `netmask`, `gateway`) before usage. - Safely iterate over `public_ips` defaulting to an empty list. Added unit tests to cover scenarios with missing keys and empty configurations. Fixes: #6602
Member
|
@karibou fyi |
holmanb
requested changes
Dec 8, 2025
Contributor
|
Obsoleted by #6617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
fix(scaleway): prevent crash on missing metadata keys (#6602)
Use safe
.get()access forprivate_ipandipv6metadata fields to avoid KeyErrors when these optional fields are missing.Additionally:
ipv6is treated as a dictionary and check for existence of required keys (address,netmask,gateway) before usage.public_ipsdefaulting to an empty list.Added unit tests to cover scenarios with missing keys and empty configurations.
Fixes GH-6602
Test Steps
Unit Tests added to
tests/unittests/sources/test_scaleway.py.Merge type