Conversation
…cted participants a dropdown, implement add button, and more
… supabase for the real data
…implement styling and design fixes so that it looks like the figma
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
thank you tanay! the ui looks really good!!
can you use the role-selection page to help populate the actual roles
and can we populate all the actual excercises we have to start from?
also, lets have start session actually start the game - you can refrence session start and role selection to see how we do this
to do this, we need the roles to populate from which template they select to play with
- first make a new query in
actions/supabase/queries/templates.tsto get all templates based on the profile user_group or if the template is accessible to all
const { data } = await supabase .from('templates') .select('*') .or(user_group.eq.${userGroup},accessible_to_all.eq.true); -
- then populate the dropdown with all these templates
- use
app/sessions/role-selection/page.tsxsee how they usefetchRoles(templateId)to get all the roles - Use the selected template to populate the roles that can be chosen from
- Have start session actually create a new session - see
handleStartGamein role-selection
lets also make is so that if they change the template they are using after assigning people, the selections reset
References:
app/sessions/role-selection/page.tsx
app/sessions/[templateId]/page.tsx
also - i added in the key movements so please pull before you start to get the updates i added!
|
Looks good Tanay! a couple things to look out for — Easy Fixes:
are all noticeably or slightly heavier than what's on the Figma Harder Fixes?
Sorry Ik its a lot but I I prioritized pointing out things that affect the consistency & cleanliness of the UI, ur doing great tho it otherwise looks good :D |
ethan-tam33
left a comment
ethan-tam33
left a comment
There was a problem hiding this comment.
great work tanay!! left some comments for you to address+fix before you merge.
| /> | ||
| </div> | ||
|
|
||
| <div style={{ flex: 1 }}> |
There was a problem hiding this comment.
avoid inline styling! move flex: 1 to styles.ts
| options={exerciseOptions} | ||
| placeholder="Select Exercise" | ||
| customStyles={ExerciseSelectStyles} | ||
| onChange={val => console.log("Exercise selected:", val)} |
|
|
||
| <ConfigRow> | ||
| <DropdownContainer> | ||
| {/* Exercise Dropdown */} |
There was a problem hiding this comment.
don't leave behind unnecessary comments
| @@ -0,0 +1,215 @@ | |||
| "use client"; | |||
There was a problem hiding this comment.
is there a reason why we have empty space on the right side of the screen? can we just center everything or make all the components wider?
@eshabansiya unsure if this is a design thing tho?
| { id: "", name: "", email: "", role: "" }, | ||
| ]); | ||
|
|
||
| // 1. Prepare options for InputDropdown (Map<value, label>) |
| return new Set(["Project Lead", "Designer", "Developer", "External"]); | ||
| }, []); | ||
|
|
||
| const exerciseOptions = useMemo(() => { |
| (nextRef: React.RefObject<SelectInstance<DropdownOption> | null>) => | ||
| (e: React.KeyboardEvent) => { | ||
| if (e.key === "Enter") { | ||
| const isMenuOpen = nextRef.current?.focus(); |
| </div> | ||
|
|
||
| <div style={{ flex: 1 }}> | ||
| <InputDropdown |
There was a problem hiding this comment.
can we add a delete button for each row? maybe that's in a future sprint though @eshabansiya
| ]); | ||
|
|
||
| // 1. Prepare options for InputDropdown (Map<value, label>) | ||
| const userOptions = useMemo(() => { |
There was a problem hiding this comment.
can we sort this alphabetically by first name? this should make it easier to find people
|
|
||
| // 1. Prepare options for InputDropdown (Map<value, label>) | ||
| const userOptions = useMemo(() => { | ||
| const map = new Map<string, string>(); |
There was a problem hiding this comment.
also @eshabansiya do you know how big this list of people can be for a session? if it can get really big, have you thought of implementing a search feature?
… the default hardcoded values from before
…e headers, sync/async boldness, select excerise dropdown height)
eshabansiya
left a comment
eshabansiya
left a comment
There was a problem hiding this comment.
thanks tanay! it looks great
i went in a fixed small styling and added a delete - by ethan's suggestion
- and i adjusted the indexing to be based on the order
have a great break!
4 participants
🦜 What's new in this PR
🦋 Description
Added entirety of exercises/start to the facilitators' flow as a standard for starting a new exercise based on Kevin's designs.
🦧 Screenshots
🐸 How to review
Test the dropdowns to see that they are as intuitive as designed, see that selected participants are from the supabase, and that everything flows appropriately without weird hiccups
🐁 Related PRs
Resolved #68
CC: @eshabansiya