Chore: remove Azure file share and mount

[lalver1]

Part of #3444

This PR will help with #3444 and #2831 by having less resources to move to the new subscription and by freeing up the App Service from the storage account, simplifying the move.

Azure file share

Since for each environment we are storing the Sqlite database file in the Azure managed /home directory, and not in an Azure file share mount, we can remove this. The file share was originally created to persist the Sqlite database in #1775 but after noticing some issues with the database being locked, the database was moved to the Azure managed /home directory in #2166.

As an extra verification of the behavior described above, we confirmed that the database file in the file share of each environment (dev, test, and prod) was last modified in June 2024, matching the date of #2166.

Recovery services vault

A recovery services vault was initially configured in #1886, but since we are not using the Azure file share anymore, we can remove this.

As an extra verification that it is not being used, we confirmed in the Azure Portal that for each environment, Protected items -> Backup items shows 0 backed up items for each category of backup type.

Terraform plan

Terraform plan shows

Plan: 0 to add, 1 to change, 4 to destroy.

as expected.

[github-actions]

Coverage report

This PR does not seem to contain any modification to coverable code.

[lalver1]

There is one more resource that can be removed, moving this back to draft to add it...

[angela-tran]

This looks good to me. Glad to have this cleaned up 🙌

[jgravois]

nice cleanup!

we discussed nuking the sacalitpd001 storage account yesterday too, but i'm under the impression that terraform isn't managing that resource. 🤙

[angela-tran]

we discussed nuking the sacalitpd001 storage account yesterday too, but i'm under the impression that terraform isn't managing that resource.

Yeah, I think it's fine to delete that one too. My memory of it is it was created before we started using Terraform. At this point, it's been sitting around unused for years.

[lalver1]

Thanks for the review everyone! I'll keep an eye out on this as it gets deployed.

And that's right @jgravois, we won't move sacalitpd001 and since it isn't being managed by Terraform, no need to clean up anything in Terraform. So it'll get deleted once we delete the RG-CDT-PUB-VIP-CALITP-D-001 resource group in CDT/ODI Development.