GH-4660: Implement GetFileSystemInfo in FileSystem, Directory and Glo…#4704
GH-4660: Implement GetFileSystemInfo in FileSystem, Directory and Glo…#4704Abde1rahman1 wants to merge 6 commits intocake-build:developfrom
Conversation
|
@microsoft-github-policy-service agree |
|
Any Updates here ?! |
Thank you for your contribution and effort here! I see that this PR introduces GetFileSystemInfo on IFileSystem and related methods on IDirectory/IGlobber. However, adding members directly to these core interfaces without a default implementation is a breaking change, which we'll need to consider carefully, as it may require a major release, as it potentially breaks ABI and any existing external dependency i.e., Cake addins. There are also no tests verifying these changes (Cake.Core Unit tests are located https://github.com/cake-build/cake/tree/develop/src/Cake.Core.Tests, and integration tests are here). Which means we'll need to allocate time and resources to carefully review this PR; we will, but can't guarantee when. |
Description
This PR addresses issue #4660 by providing a way to retrieve file system entries (files and directories) without needing to know the type beforehand.
Changes
GetFileSystemInfotoIFileSystem.GetFileSystemInfostoIDirectoryandIGlobber.FileSystem,Directory,Globberand theirFakecounterparts.