Skip to content

GH-4660: Implement GetFileSystemInfo in FileSystem, Directory and Glo…#4704

Open
Abde1rahman1 wants to merge 6 commits intocake-build:developfrom
Abde1rahman1:feature/get-filesystem-info
Open

GH-4660: Implement GetFileSystemInfo in FileSystem, Directory and Glo…#4704
Abde1rahman1 wants to merge 6 commits intocake-build:developfrom
Abde1rahman1:feature/get-filesystem-info

Conversation

@Abde1rahman1
Copy link

Description

This PR addresses issue #4660 by providing a way to retrieve file system entries (files and directories) without needing to know the type beforehand.

Changes

  • Added GetFileSystemInfo to IFileSystem.
  • Added GetFileSystemInfos to IDirectory and IGlobber.
  • Implemented changes in FileSystem, Directory, Globber and their Fake counterparts.

@Abde1rahman1
Copy link
Author

@microsoft-github-policy-service agree

@Abde1rahman1
Copy link
Author

Any Updates here ?!

@devlead
Copy link
Member

devlead commented Feb 15, 2026

Any Updates here ?!

Thank you for your contribution and effort here! I see that this PR introduces GetFileSystemInfo on IFileSystem and related methods on IDirectory/IGlobber.

However, adding members directly to these core interfaces without a default implementation is a breaking change, which we'll need to consider carefully, as it may require a major release, as it potentially breaks ABI and any existing external dependency i.e., Cake addins.

There are also no tests verifying these changes (Cake.Core Unit tests are located https://github.com/cake-build/cake/tree/develop/src/Cake.Core.Tests, and integration tests are here). Which means we'll need to allocate time and resources to carefully review this PR; we will, but can't guarantee when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants