Open
Conversation
jbreue16
reviewed
Mar 10, 2026
Contributor
jbreue16
left a comment
There was a problem hiding this comment.
For the CI failing to build under windows: We've defined
Since we agreed on making cpp20 the new standard for cadet-core, which will be mandatory anyways once #592 is merged, you could also use the following, which is possible with cpp20 upwards
#include <numbers> std::numbers::pi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the CPA binding model by Briskot et al. (2021)
Todo:
Discussion points: