Skip to content

Add CPA binding model#611

Open
AntoniaBerger wants to merge 2 commits intomasterfrom
feature/add_CPA_binding_model
Open

Add CPA binding model#611
AntoniaBerger wants to merge 2 commits intomasterfrom
feature/add_CPA_binding_model

Conversation

@AntoniaBerger
Copy link
Collaborator

@AntoniaBerger AntoniaBerger commented Mar 9, 2026

This PR will add the CPA binding model by Briskot et al. (2021)

Todo:

  • Implement Residual
  • Implement Jacobin
  • Enable rapid equilibrium
  • Add tests to CI
  • Add tests to verification
  • Add documentation

Discussion points:

  • How to handle pH?
  • Support different AS functions in this model?

@AntoniaBerger AntoniaBerger changed the title Add residual implementation Add CPA binding model Mar 9, 2026
Copy link
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI failing to build under windows: We've defined $\pi$ in a lot of functions and it should be optimzed away, i.e. inlined.
Since we agreed on making cpp20 the new standard for cadet-core, which will be mandatory anyways once #592 is merged, you could also use the following, which is possible with cpp20 upwards
#include <numbers> std::numbers::pi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants