Draft
Conversation
Collaborator
|
Are you planning to change the warning settings so that the unsigned/signed comparison warnings are no longer visible? |
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
5e90924 to
b467f86
Compare
Contributor
|
Hi, please rebase onto master, i fixed some local variable shadowing issues. |
freeware-superman
force-pushed
the
fix/compile-warnings
branch
5 times, most recently
from
edb7cb4 to
51fdbb3
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
2 times, most recently
from
85b5fb1 to
d26e514
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
4 times, most recently
from
0befba3 to
76a12c4
Compare
src/libcadet/model/binding/HICWaterOnHydrophobicSurfacesBinding.cpp
Outdated
Show resolved
Hide resolved
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
e5affee to
848751a
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
67b34b4 to
090a681
Compare
src/libcadet/model/parts/TwoDimensionalConvectionDispersionOperatorDG.cpp
Show resolved
Hide resolved
jbreue16
reviewed
Mar 7, 2026
Contributor
jbreue16
left a comment
jbreue16
left a comment
There was a problem hiding this comment.
Hi there, thanks for working on this, seems like many warnings are fixed already !
What warnings are left? I think we should merge this and continue on another PR
Since C++23, empty spaces between quotation marks and suffixes are deprecated.
The lines changed were indented in a way that may lead to confusion when not reading extra carefully.
Not including the header may lead to undefinded behaviour.
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
ee4f332 to
085b50f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves all issues leading to compile warnings. Already excluded warnings do not get resolved. -Wsign-compare will be handled in a seperate PR as it needs a lot more changes.
Some smaller issues that are found along the way get resolved as well.