Add hybrid modeling with neural-network-based binding models#501
Open
Add hybrid modeling with neural-network-based binding models#501
Conversation
…del unit operation
…se statement in LRMwoP.cpp
…ach but the work is still in progress
…nd then perform the fitting process within CADET
…se statement in LRMwoP.cpp
…ach but the work is still in progress
…nd then perform the fitting process within CADET
…ET binding model library
The added comments will aid the documentation related to creating and adding a new binding model in CADET.
|
Thank you for your submission, we really appreciate it! Like many open-source projects we ask that you sign our Contributor License Agreement before we can accept your contribution.
- [ ] The CADET maintainers know my real name.
At least one of the following two applies:
- [ ] The CADET maintainers know my current employer.
- [ ] I am *not* making this contribution on behalf of my current employer.
|
Contributor
|
Unfortunately, rebasing was not possible without additional work. Amongst other issues, the PR includes changes to the unit operation models and it's not quite clear yet as to why. I see the following options:
Any preference @lieres? |
Member
|
@jazib-hassan-juelich, please have a look and comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces hybrid models to CADET-Core, allowing the binding model to be replaced or approximated by a pre-trained neural network.
Todo
src/mklstuff and use Eigen3 instead for matrix vector operationsColumnModel1D.cpp,ColumnModel2D.cpp