Add rapid equilibrium reactions for CSTR#324
Conversation
|
if you write the keyword to close the issue right in front of the corresponding issue, it will automatically be closed when the PR is merged. I.e. writing "fixes" instead of "resolves therefore" in the PR description .. maybe "resolves" also works |
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include <Eigen/Dense> |
There was a problem hiding this comment.
I think its time to make Eigen obligatory for CADET.
Currently, Eigen is only installed when the ENABLE_DG flag is set to ON (which is the default)
So when you are using Eigen in another submodule, the build will fail when ENABLE_DG is OFF
We can either make Eigen obligatory for CADET or you also guard the rapid-equilibrium reaction code with compile time flags checking for Eigen.
You can see this e.g. under /src/libcadet/CMakeLists.txt where the DG units are only included if the flag is ON
This is only relevant for the merge into master, so for now you can also just set this as the last todo in your todo list
1765bfd to
6a4367e
Compare
- to residiumImpl - jacobian - jacderivative
little changes
52023f9 to
85df024
Compare
…d of iteration simple example works without consistent initalisation fix conserved moities calculation
3a3ed1d to
1d033f5
Compare
1d033f5 to
6ddcd08
Compare
This way we are more flexible to use conserved moities in for different units.
c666401 to
7be73be
Compare
Fixes #20.
This PR will add the feature to set reactions into a rapid equilibrium in liquid phase for the CSTR
Workflow:
More information about the algorithm are available under the forum post about reactions in rapid equilibrium