test: Increase code coverage for admin failover commands

[c-warren]

What changed?

Adds test coverage for admin_failover_commands.go.

Why?

We were below 80% coverage in admin_failover_commands, which blocked another PR.

How did you test it?

It is tests.

Potential risks

We could have TOO MUCH test coverage.

Release notes

N/A

Documentation Changes

N/A

[gitar-bot]

CI failed: Integration tests failed during the 'cover_integration_profile' execution due to timeouts and polling failures in the matching service, likely triggered by added test load in the new admin failover test.

Overview

The cover_integration_profile build failed during integration testing. The logs show repeated service-level timeouts and polling failures within the matching service (PollForActivityTask and PollForDecisionTask), suggesting that the tests introduced in this PR are causing performance degradation or synchronization contention under coverage instrumentation.

Failures

Matching Service Timeout/Contention (confidence: medium)

• Type: test
• Affected jobs: 79156029937
• Related to change: yes
• Root cause: The inclusion of new admin failover command tests in admin_failover_commands_test.go likely creates heavy load or race conditions in the matching service. The stack trace points to PollForActivityTask and PollForDecisionTask repeatedly failing after being invoked by the test suite.
• Suggested fix: Review admin_failover_commands_test.go to ensure all asynchronous operations are correctly synchronized and awaited. If the logic is sound, consider increasing the timeout duration for the cover_integration_profile in the Makefile, as instrumented code runs significantly slower and may exceed default thresholds.

Summary

• Change-related failures: 1 (Integration test failure directly associated with new test coverage for admin commands)
• Infrastructure/flaky failures: 0
• Recommended action: Audit the new test suite for race conditions and consider increasing the test timeout settings to accommodate the overhead of code coverage instrumentation.

Code Review ✅ Approved

Expands test suite coverage for admin failover commands including workflow list, query, and rollback operations. No issues found.

Rules ❌ No requirements met

Repository Rules

❌ GitHub Issue Linking Requirement: The PR exceeds 50 lines changed (93 lines) but lacks a reference to a cadence-workflow issue in its description.

❌ PR Description Quality Standards: The PR description lacks sufficient technical rationale in the 'Why?' section and does not include concrete, copyable test commands in the 'How did you test it?' section.

_{1 rule not applicable. Show all rules by commenting gitar display:verbose.}

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}