chore: bump cadence-idl to d6d4d81 (adds state to CreateScheduleRequest) - #1083
Merged
Conversation
Adds ScheduleState state = 8 to the CreateScheduleRequest proto message, and adds the corresponding state field to the generated thrift Java class. This is a prerequisite for creating schedules in a paused initial state. Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
abhishekj720
requested review from
demirkayaender,
dkrotx,
natemort and
shijiesheng
as code owners
August 21, 2026 00:10
2 tasks
Code Review ✅ ApprovedBumps the cadence-idl submodule and regenerates the CreateScheduleRequest Java class to include state. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
YaweiZhang-930
approved these changes
Aug 21, 2026
c-warren
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
src/main/idlssubmodule from3ee08a9tod6d4d81and updates the generated thrift Java class accordingly.Why
cadence-idl #276 added
ScheduleState state = 8toCreateScheduleRequestin both the proto and thrift IDLs. This is a prerequisite for the Java client to support creating schedules in a paused initial state.Changes
src/main/idlssubmodule →d6d4d81src/gen/java/com/uber/cadence/CreateScheduleRequest.java— addsprivate ScheduleState statefield (generated from updated thrift IDL)Follow-up
PR #1082 builds on this to add
ScheduleInitialStateand the five-argcreateSchedule()overload.