Skip to content

fix(client): feature flags header should not serialize private fields - #1079

Merged
shijiesheng merged 3 commits into
cadence-workflow:v3.13.xfrom
shijiesheng:v3-fix-featureflag
Aug 18, 2026
Merged

fix(client): feature flags header should not serialize private fields#1079
shijiesheng merged 3 commits into
cadence-workflow:v3.13.xfrom
shijiesheng:v3-fix-featureflag

Conversation

@shijiesheng

@shijiesheng shijiesheng commented Aug 15, 2026

Copy link
Copy Markdown
Member

What changed?

  • Feature flags header's serializer should ignore all private fields (so it's not serialized into the blob)
  • Also bundled other test fixes to bring all tests to green again chore(test): fix test flakiness due to tchannel span assertion #1077
    ** disabled several TChannel tests with trace enabled. It won't work for OSS server due to the grpc constraint. We are sunsetting V3 anyway; internally we have a grpc-go fork that allows forwarding headers like $trace$-xxx
    ** flaky tests due to race conditions of TChannel span activation.

Why?

Java's thrift encoder would add private fields like "__isset_bitfield". These additional fields cause the server to ignore all feature flags due to a bug (fix in the server cadence-workflow/cadence#8421)

How did you test it?

Unit Test + Integration Test

Potential risks

Release notes

Documentation Changes

Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
…gher grpc

Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
… thrift serialization

Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
@shijiesheng shijiesheng changed the title V3 fix featureflag fix(client): feature flags header should not serialize private fields Aug 15, 2026
@gitar-bot

gitar-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates the feature flags serializer to ignore private fields and includes test stability fixes. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@shijiesheng
shijiesheng merged commit 36ed687 into cadence-workflow:v3.13.x Aug 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants