fix(client): feature flags header should not serialize private fields - #1079
Merged
shijiesheng merged 3 commits intoAug 18, 2026
Merged
Conversation
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
…gher grpc Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
… thrift serialization Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
shijiesheng
requested review from
abhishekj720,
demirkayaender,
dkrotx and
natemort
as code owners
August 15, 2026 01:03
Code Review ✅ ApprovedUpdates the feature flags serializer to ignore private fields and includes test stability fixes. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
natemort
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
** disabled several TChannel tests with trace enabled. It won't work for OSS server due to the grpc constraint. We are sunsetting V3 anyway; internally we have a grpc-go fork that allows forwarding headers like
$trace$-xxx** flaky tests due to race conditions of TChannel span activation.
Why?
Java's thrift encoder would add private fields like "__isset_bitfield". These additional fields cause the server to ignore all feature flags due to a bug (fix in the server cadence-workflow/cadence#8421)
How did you test it?
Unit Test + Integration Test
Potential risks
Release notes
Documentation Changes