Always upload artifacts - #1016
Merged
Merged
Conversation
Contributor
Author
|
Now uploads artifacts even if it fails (but the unit test has to run enough that it creates the files or else there won't be anything to upload) |
mandyschen
marked this pull request as ready for review
July 31, 2025 21:20
mandyschen
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort,
shijiesheng and
taylanisikdemir
as code owners
July 31, 2025 21:20
pandeyanshuman
pushed a commit
to pandeyanshuman/cadence-java-client
that referenced
this pull request
Oct 13, 2025
* Always upload artifacts * Test upload after fail * Try with running test * Remove forced fail --------- Co-authored-by: Mandy Chen <mandy.chen@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Always run upload artifacts
Why?
To be able to see failures more easily
How did you test it?
Will test using Github Actions
Potential risks
Release notes
Documentation Changes