refactor(various): Add type hints to couple modules in cabotage.utils and cabotage.celery packages - #377
Draft
Alc-Alc wants to merge 19 commits into
Draft
refactor(various): Add type hints to couple modules in cabotage.utils and cabotage.celery packages#377Alc-Alc wants to merge 19 commits into
cabotage.utils and cabotage.celery packages#377Alc-Alc wants to merge 19 commits into
Conversation
…s` and `cabotage.celery` packages build(redis): Major update from 7.4.0 to 8.0.1 build(typing): Add `pyrefly` and configure strict preset build(typing): Add `types-hvac` build(typing): Remove `types-redis` as redis v8 comes with better (but conflicting) type hints
Alc-Alc
marked this pull request as draft
July 13, 2026 17:10
Author
|
For context, after adding Pyrefly (no other changes) As of this PR: Reemphasizing that this is using the strictest mode it offers. |
fix(typing): Minor leftover commits
…zed manner, not targeting any particular module
Alc-Alc
force-pushed
the
add-types
branch
4 times, most recently
from
August 3, 2026 19:21
69c63a8 to
63ea4da
Compare
added 5 commits
August 5, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(various): Add type hints to couple modules in
cabotage.utilsandcabotage.celerypackagesbuild(redis): Major update from 7.4.0 to 8.0.1
build(typing): Add
pyreflyand configure strict presetbuild(typing): Add
types-hvacbuild(typing): Remove
types-redisas redis v8 comes with better (but conflicting) type hintsDescription
strtypes can be changed toLiteral['whatever']and vice-versa. I am not confident enough with the domain to make the call, for the most part I defaulted tostrunless I was sure.tyfailed to catch. This is the only functional change made.Reference to issue
Review request
Breaking changes