refactor HF reference config and pretrain defaults - #27
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 87.30% 87.36% +0.05%
==========================================
Files 132 132
Lines 6183 6236 +53
Branches 594 602 +8
==========================================
+ Hits 5398 5448 +50
+ Misses 551 550 -1
- Partials 234 238 +4 ☔ View full report in Codecov by Harness. |
AllanChain
force-pushed
the
improve-pretrain
branch
3 times, most recently
from
April 28, 2026 02:10
66d45ef to
3007197
Compare
pretrain.*
AllanChain
marked this pull request as draft
June 12, 2026 02:26
- Move HF reference settings from `system.*` to `pretrain.reference.*` so the system block stays physics-only. - Support specifying PySCF verbosity and other parameters. - Default HF is unrestricted (UHF/KUHF) unless the method selects RHF/KRHF. - Use HF distribution for pretraining by default. - Use a constant learning rate for pretraining by default. - Solid evaluation includes `reference.*` configs because HF is needed to get k-points. - Handle empty spin blocks in `slogdet` for SCF wavefunctions.
AllanChain
force-pushed
the
improve-pretrain
branch
from
July 6, 2026 01:47
f42a0a2 to
5bf71a9
Compare
AllanChain
marked this pull request as ready for review
July 6, 2026 02:02
WeiluoRen-ByteDance
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system.*topretrain.reference.*so the system block stays physics-only.reference.*configs because HF is needed to get k-points.slogdetfor SCF wavefunctions.