Skip to content

refactor HF reference config and pretrain defaults - #27

Merged
AllanChain merged 1 commit into
mainfrom
improve-pretrain
Jul 6, 2026
Merged

refactor HF reference config and pretrain defaults#27
AllanChain merged 1 commit into
mainfrom
improve-pretrain

Conversation

@AllanChain

@AllanChain AllanChain commented Apr 28, 2026

Copy link
Copy Markdown
Member
  • Move HF reference settings from system.* to pretrain.reference.* so the system block stays physics-only.
  • Support specifying PySCF verbosity and other parameters.
  • Default HF is unrestricted (UHF/KUHF) unless the method selects RHF/KRHF.
  • Use HF distribution for pretraining by default.
  • Use a constant learning rate for pretraining by default.
  • Solid evaluation includes reference.* configs because HF is needed to get k-points.
  • Handle empty spin blocks in slogdet for SCF wavefunctions.

@codecov-commenter

codecov-commenter commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.88235% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.36%. Comparing base (8845e93) to head (5bf71a9).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/jaqmc/app/solid/workflow.py 77.77% 4 Missing and 2 partials ⚠️
src/jaqmc/utils/atomic/scf.py 81.81% 2 Missing and 2 partials ⚠️
src/jaqmc/app/molecule/workflow.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   87.30%   87.36%   +0.05%     
==========================================
  Files         132      132              
  Lines        6183     6236      +53     
  Branches      594      602       +8     
==========================================
+ Hits         5398     5448      +50     
+ Misses        551      550       -1     
- Partials      234      238       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@AllanChain
AllanChain force-pushed the improve-pretrain branch 3 times, most recently from 66d45ef to 3007197 Compare April 28, 2026 02:10
Comment thread docs/systems/molecule/index.md Outdated
@AllanChain AllanChain changed the title move HF reference config under pretrain.* refactor HF reference config, defaults, and SCF edge cases May 5, 2026
@AllanChain AllanChain changed the title refactor HF reference config, defaults, and SCF edge cases refactor HF reference config and SCF defaults May 5, 2026
@AllanChain AllanChain changed the title refactor HF reference config and SCF defaults refactor HF reference config and pretrain defaults May 5, 2026
@AllanChain
AllanChain marked this pull request as draft June 12, 2026 02:26
- Move HF reference settings from `system.*` to `pretrain.reference.*`
so the system block stays physics-only.
- Support specifying PySCF verbosity and other parameters.
- Default HF is unrestricted (UHF/KUHF) unless the method selects
RHF/KRHF.
- Use HF distribution for pretraining by default.
- Use a constant learning rate for pretraining by default.
- Solid evaluation includes `reference.*` configs because HF is needed
to get k-points.
- Handle empty spin blocks in `slogdet` for SCF wavefunctions.
@AllanChain
AllanChain marked this pull request as ready for review July 6, 2026 02:02
@AllanChain
AllanChain merged commit 2c215c3 into main Jul 6, 2026
13 checks passed
@AllanChain
AllanChain deleted the improve-pretrain branch July 6, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants