Set current thread before lowering stream/future reads#12736
Draft
TartanLlama wants to merge 1 commit intobytecodealliance:mainfrom
Draft
Set current thread before lowering stream/future reads#12736TartanLlama wants to merge 1 commit intobytecodealliance:mainfrom
TartanLlama wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
wasmtime:api
alexcrichton
approved these changes
Mar 5, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Longer-term (@dicej you may have thoughts on this too) I feel like the juggling here is pretty brittle and it seems like we should have a new argument to LowerContext::new or something like that. I'm not sure if that would work well given all the various juggling involved, but might be something worth considering.
| mut store: StoreContextMut<T>, | ||
| caller: RuntimeComponentInstanceIndex, | ||
| caller_instance: RuntimeComponentInstanceIndex, | ||
| caller_thread: QualifiedThreadId, |
Member
There was a problem hiding this comment.
I think this argument is always self.concurrent_state_mut().current_guest_thread()?, so could the argument be dropped and that inlined directly below?
| let id = TableId::<TransmitHandle>::new(rep); | ||
| log::trace!("copy values {values:?} for {id:?}"); | ||
|
|
||
| store.0.set_thread(read_caller_thread)?; |
Member
There was a problem hiding this comment.
Mind leaving comments here, and above, for why the current thread is set?
Also, is this something where we want to restore the previous thread after this finishes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current thread is not set before lowering the results of stream/future reads, which can potentially call
realloc.Putting this up as a draft for now as I'm off tomorrow, will add some tests for this on Monday.