s390x-z17: Implement load indexed address instruction#12707
Draft
theotherjimmy wants to merge 1 commit intobytecodealliance:mainfrom
Draft
s390x-z17: Implement load indexed address instruction#12707theotherjimmy wants to merge 1 commit intobytecodealliance:mainfrom
theotherjimmy wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Member
|
cc @uweigand |
github-actions
bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
theotherjimmy
force-pushed
the
z17-lxa
branch
2 times, most recently
from
b7410c0 to
ee70f7f
Compare
Contributor
Author
|
Big refactor to avoid expanding the Inst enum. Still needs some runtests, and running said tests. |
Contributor
Author
|
I added rustfmt check to my auto-test script. Sorry I missed that earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Z17, s390x includes some specialized indexed address computation instruction that allow for computing addresses in a way that could map to finding an element within an array, skipping over a structure header of a constant size. While this does not also load the address, it is usually more efficient, at least in terms of code size, to use this newer load indexed address (lxa, llxa) instruction instead of expanded address computations using add instructions.
This is currently created as a draft, as I'm figuring out how to test this. I think testing is needed, as it's a specific sequence of IR instructions, and while I'm confident that I have them correct, it's better to be certain with testing.