fix: Wrong compiler parameter on MSVC

[sbwtw]

fix wrong compiler param -mindirect-branch-register on MSVC

[lum1n0us]

The -mndirect-branch-register is a Clang-specific option. I would suggest a shorter form like the one below.

if (CMAKE_C_COMPILER MATCHES ".*clang.*" OR CMAKE_C_COMPILER_ID MATCHES ".*Clang")
  set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mindirect-branch-register")
endif ()

It seems we should reduce the repetition of this code segment. I suggest moving this piece of code(the optimized version) to config_common.cmake. I haven't tested this idea before, so please let me know if it doesn't work if you decide to give it a try.

[sbwtw]

The -mndirect-branch-register is a Clang-specific option. I would suggest a shorter form like the one below.

if (CMAKE_C_COMPILER MATCHES ".*clang.*" OR CMAKE_C_COMPILER_ID MATCHES ".*Clang")
  set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mindirect-branch-register")
endif ()

It seems we should reduce the repetition of this code segment. I suggest moving this piece of code(the optimized version) to config_common.cmake. I haven't tested this idea before, so please let me know if it doesn't work if you decide to give it a try.

I moved these codes to config_common, and i found clang doesn't support -mindirect-branch-register. it's gcc only.

[lum1n0us]

it's gcc only.

You are right. My mistaken.

[sbwtw]

Hi @lum1n0us , Thanks for your review. and I resolved all issues. please have a look

[lum1n0us]

LGTM