Conversation
First-time image preparation can block sandbox creation long enough that the CLI looks hung. Add a TTY-only spinner around CreateSandbox so users get immediate feedback while provisioning is still in progress.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 971ff8bc58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if stderr == nil { | ||
| return | ||
| } | ||
| _, _ = fmt.Fprintf(stderr, "\r[%s] Preparing sandbox (first use may take a bit)... %s", frame, formatSandboxProgressDuration(elapsed)) |
There was a problem hiding this comment.
The frame writer only prefixes with \r and never clears the current line, so once the elapsed string becomes shorter (for example transitioning from 950ms to 1.1s after ~1s of provisioning) stale suffix characters remain on screen, producing garbled progress text during long sandbox creation. This is user-visible whenever provisioning takes long enough for the formatted duration width to shrink, and it can be fixed by clearing the line (or using fixed-width formatting) before each frame write.
Useful? React with 👍 / 👎.
Make sandbox creation progress honor the CLI's ANSI policy and only report success after the create response has been validated. Add regression tests for failure reporting and NO_COLOR behavior.
1 participant
Summary
CreateSandboxis blocked on provisioningsandbox createand implicit sandbox creation fromexecTesting
mise exec -- go test ./...