refactor: runtime asset installs around prefix libexec layout#132
refactor: runtime asset installs around prefix libexec layout#132
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe402efc9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lox
changed the title
lox
force-pushed
the
codex/prefix-libexec-install-layout
branch
from
e32b065 to
97eec4e
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36c250640d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if helper_supports_capability_probe "$candidate"; then | ||
| if [[ -n "${PREFERRED_PRIVILEGED_HELPER_PATH:-}" && "$candidate" != "$PREFERRED_PRIVILEGED_HELPER_PATH" ]]; then | ||
| echo "falling back from $PREFERRED_PRIVILEGED_HELPER_PATH to $candidate for non-interactive helper access" |
There was a problem hiding this comment.
resolve_privileged_helper_path is used via command substitution (PRIVILEGED_HELPER_PATH="$(resolve_privileged_helper_path)"), but in the fallback case it writes both a status message and the selected path to stdout. When CLEANROOM_PRIVILEGED_HELPER_PATH is set but unusable and the script falls back to another helper, PRIVILEGED_HELPER_PATH becomes a multi-line string containing the log message, so subsequent sudo -n "$PRIVILEGED_HELPER_PATH" capabilities calls fail even though a valid fallback helper exists.
Useful? React with 👍 / 👎.
lox
force-pushed
the
codex/prefix-libexec-install-layout
branch
from
36c2506 to
b5244a4
Compare
1 participant
Summary
dist/<os>-<arch>/binanddist/<os>-<arch>/libexec/cleanroom${prefix}/libexec/cleanroom, keepingcleanroomas the only public CLI in${prefix}/binTesting
bash -n scripts/benchmark-sandbox-workloads.sh scripts/benchmark-tti.sh scripts/bootstrap-buildkite-agent.sh scripts/bootstrap-cleanroom-host.sh scripts/build-darwin-vz-helper.sh scripts/build-go.sh scripts/ci-cleanroom-e2e.sh scripts/ci-darwin-vz-e2e.sh scripts/ci-darwin-vz-vmnet-e2e.sh scripts/cleanroom-root-helper.sh scripts/install-global.sh scripts/install-go.sh scripts/install.sh scripts/prepare-firecracker-image.sh scripts/dist-layout.shgo test ./internal/runtimeassets ./internal/backend/darwinvz ./internal/backend/firecracker ./scriptsgo test ./...