Draft
Conversation
0b18a5e to
25ca84e
Compare
4d6971c to
eade9df
Compare
9a4591e to
7bbbff9
Compare
gingerbenw
commented
Feb 3, 2025
| error, | ||
| true, | ||
| handledState, | ||
| 1 |
Member
Author
There was a problem hiding this comment.
Looking at the signature for Event.create the errorFramesToSkip parameter should be the 5th - the 4th parameter should be for the component name
node: TypeScript and rollup
core: move tests from src to test
core: move to src, add TypeScript and rollup
Merge branch 'next' into integration/typescript
…m-main Merge latest changes into integration/typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Convert packages to TypeScript using rollup to bundle both ES modules and Common JS modules for maximum compatibility
Changeset
Testing
Covered by CI
Outstanding