[MidEnd] refactor staticize-memref-layout#683
Open
AkunCube wants to merge 1 commit intobuddy-compiler:mainfrom
Open
[MidEnd] refactor staticize-memref-layout#683AkunCube wants to merge 1 commit intobuddy-compiler:mainfrom
AkunCube wants to merge 1 commit intobuddy-compiler:mainfrom
Conversation
AkunCube
changed the title
AkunCube
force-pushed
the
refactor-static-memref-layout
branch
from
49ac1d5 to
3671248
Compare
Member
|
@zhanghb97 https://github.com/llvm/llvm-project/blob/a17bc05818264a1eef3796cc5b0856a3cd3e808b/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp#L2192 .I found a similar pattern in the latest MLIR, so we might be able to remove ReinterpretCastFolder in a future update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think what this Pass is supposed to do is convert the
stridesandoffsetsofmemref.reinterpret_castintoIntAttrs. Also, I checked the test case attests/Conversion/staticize-memref-layout.mlir, and it seems that we can draw onOpWithOffsetSizesAndStridesConstantArgumentFolderfromllvm/mlir/include/mlir/Interfaces/ViewLikeInterface.hIt works the same as before, with no extra test cases added yet.