fix(core): pass local profile dir as Chrome flag#2237
Open
luochen211 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 8d04ca6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run. |
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Test as Regression Test
participant Launch as launchLocalChrome()
participant Flags as ChromeFlags Builder
participant Launcher as chrome-launcher
Note over Test,Launcher: Launch flow
Test->>Launch: call with userDataDir option
Launch->>Flags: build chromeFlags array
Flags->>Flags: append "--user-data-dir=<path>"
Flags-->>Launch: chromeFlags list
Launch->>Launcher: launch({ chromeFlags, ignoreDefaultFlags })
Note over Launch,Launcher: userDataDir NOT passed to launcher
Launcher->>Launcher: start Chrome with flags
Launcher-->>Launch: browser instance
Note over Test,Launcher: Assertion path
Test->>Launch: getLaunchArgs() captures launcher options
alt userDataDir option absent from launcher
Test-->>Test: expect args.userDataDir to be undefined
end
alt chromeFlags contains user-data-dir
Test-->>Test: expect "--user-data-dir=<path>" in flags
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1503
Tests
Summary by cubic
Fix local Chrome profile handling by passing
--user-data-dirdirectly to Chrome instead of viachrome-launcher, avoiding path conversion and making local profiles work reliably. Fixes #1503.--user-data-dir=<path>to Chrome flags; stop sendinguserDataDirtochrome-launcher.Written for commit 8d04ca6. Summary will update on new commits.