You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This changes ActCache key derivation so query parameter order no longer causes silent cache misses. The raw page URL is still stored in the cache entry for debugging. Only the hash input is normalized.
I also added a legacy raw URL key fallback. That keeps existing cache files reachable after the normalized key starts being used, instead of making old entries quietly unreachable.
What changed
Added normalizeUrlForCacheKey for conservative query parameter sorting.
Used the normalized URL when building Act cache keys.
Preserved the raw pageUrl in ActCacheContext and stored cache entries.
Added legacyCacheKey fallback reads for old raw URL cache files.
Added tests for reordered query params, stable URLs, malformed inputs, repeated params, and legacy fallback replay.
Validation
bunx prettier --check on changed files passed.
git diff --check passed.
Direct Bun runtime check for normalizeUrlForCacheKey passed.
Could not run the full Vitest path locally because pnpm is not installed in this checkout, and bunx vitest fails before running tests due a Rolldown native binding code signature error on macOS. Bundling ActCache directly also hits Stagehand's generated version file, so I left the full suite to CI.
Summary by cubic
Normalize Act cache keys by sorting URL query parameters so reordering no longer causes cache misses. Adds a legacy raw-URL fallback to keep existing cache entries accessible (fixes#2189).
Bug Fixes
Use a normalized URL only for cache key hashing; keep the raw pageUrl in context and stored entries.
Fallback to legacy raw-URL keys when normalized reads miss, preserving access to old cache files.
Add tests for param reordering, repeated params, malformed inputs, stable URLs, and legacy fallback.
Written for commit bee1a21. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2189.
This changes ActCache key derivation so query parameter order no longer causes silent cache misses. The raw page URL is still stored in the cache entry for debugging. Only the hash input is normalized.
I also added a legacy raw URL key fallback. That keeps existing cache files reachable after the normalized key starts being used, instead of making old entries quietly unreachable.
What changed
Validation
Could not run the full Vitest path locally because pnpm is not installed in this checkout, and bunx vitest fails before running tests due a Rolldown native binding code signature error on macOS. Bundling ActCache directly also hits Stagehand's generated version file, so I left the full suite to CI.
Summary by cubic
Normalize Act cache keys by sorting URL query parameters so reordering no longer causes cache misses. Adds a legacy raw-URL fallback to keep existing cache entries accessible (fixes #2189).
pageUrlin context and stored entries.Written for commit bee1a21. Summary will update on new commits.