Skip to content

fix(core): normalize Act cache URL keys#2227

Draft
RitwijParmar wants to merge 1 commit into
browserbase:mainfrom
RitwijParmar:codex/stagehand-normalize-act-cache-url
Draft

fix(core): normalize Act cache URL keys#2227
RitwijParmar wants to merge 1 commit into
browserbase:mainfrom
RitwijParmar:codex/stagehand-normalize-act-cache-url

Conversation

@RitwijParmar

@RitwijParmar RitwijParmar commented Jun 10, 2026

Copy link
Copy Markdown

Fixes #2189.

This changes ActCache key derivation so query parameter order no longer causes silent cache misses. The raw page URL is still stored in the cache entry for debugging. Only the hash input is normalized.

I also added a legacy raw URL key fallback. That keeps existing cache files reachable after the normalized key starts being used, instead of making old entries quietly unreachable.

What changed

  • Added normalizeUrlForCacheKey for conservative query parameter sorting.
  • Used the normalized URL when building Act cache keys.
  • Preserved the raw pageUrl in ActCacheContext and stored cache entries.
  • Added legacyCacheKey fallback reads for old raw URL cache files.
  • Added tests for reordered query params, stable URLs, malformed inputs, repeated params, and legacy fallback replay.

Validation

  • bunx prettier --check on changed files passed.
  • git diff --check passed.
  • Direct Bun runtime check for normalizeUrlForCacheKey passed.

Could not run the full Vitest path locally because pnpm is not installed in this checkout, and bunx vitest fails before running tests due a Rolldown native binding code signature error on macOS. Bundling ActCache directly also hits Stagehand's generated version file, so I left the full suite to CI.


Summary by cubic

Normalize Act cache keys by sorting URL query parameters so reordering no longer causes cache misses. Adds a legacy raw-URL fallback to keep existing cache entries accessible (fixes #2189).

  • Bug Fixes
    • Use a normalized URL only for cache key hashing; keep the raw pageUrl in context and stored entries.
    • Fallback to legacy raw-URL keys when normalized reads miss, preserving access to old cache files.
    • Add tests for param reordering, repeated params, malformed inputs, stable URLs, and legacy fallback.

Written for commit bee1a21. Summary will update on new commits.

Review in cubic

@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bee1a21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.

@github-actions github-actions Bot added external-contributor Tracks PRs mirrored from external contributor forks. external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. external-contributor Tracks PRs mirrored from external contributor forks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core(cache): ActCache key derivation isn't URL-normalized, causing silent cache misses

1 participant