Added sysfs monitoring bar variables#2285
Open
mfluhr wants to merge 2 commits intobrndnmtthws:mainfrom
Open
Conversation
✅ Deploy Preview for conkyweb canceled.
|
c3b6f5c to
ed021ea
Compare
brndnmtthws
requested changes
Jan 16, 2026
Owner
brndnmtthws
left a comment
There was a problem hiding this comment.
Thanks for the addition. I think there are a couple issues to fix before merge:
- platformbar is wired to parse_i2c_bar, so it uses the i2c sysfs path and will not find platform devices. It should call parse_platform_bar. (src/core.cc)
- sysfs_sensor_barval clamps negative values to 100.0 instead of 0.0, so a negative value shows a full bar. (src/data/os/linux.cc)
Please address these and I’m happy to re-review.
✅ Deploy Preview for conkyweb canceled.
|
Contributor
Author
|
Whoops.... Those were 2 very dumb mistakes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I used "hwmon" for years now to monitor my CPU core temps, but needed to fallback to an execbar to have those values shown as bar nearby. Since doing so for all cores is quite heavy, I added some sysfs bar variables (hwmonbar, i2cbar and platformbar) that basically fill this gap. Doing so, spared me some CPU usage.
The code should not affect existing conky configurations, since it is new variables addition.
I tested this using the "hwmonbar" variable to monitor my AMD CPU core package temps, replacing this
${execbar sensors -u k10temp-pci-00c3 | grep temp1_input | awk '{print $2}' | cut -d '.' -f1}with this
${hwmonbar k10temp temp2 1 1.0 0.0}One important note: Due to the bar scaling when calling setup_bar(), the factor and offset should be adjusted properly so that the value is always inside a 0-100 range.