Fix issue 61: checking Stan version: https://github.com/brian-lau/Mat… #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex to check the Stan version will be more robust if we: 1) *match* on the first string of numerals and dots following a "v": '(?<=v)[0-9\.]+' 2) *split* on "." and cast the chunks to integers as before On branch master Changes to be committed: modified: StanModel.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 61:
The regex to check the cmdstan version is broken, but the suggestion in the issue did not resolve the issue on Centos.
The regex to check the Stan version will be more robust if we:
On branch master
Changes to be committed:
modified: StanModel.m