Skip to content

Fix object store lifecycle management for dulwich 0.25+ #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelmer merged 1 commit into from
Jan 11, 2026
Merged

Fix object store lifecycle management for dulwich 0.25+ #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions breezy/git/transportgit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,19 @@ def __eq__(self, other):
def __repr__(self):
return "{}({!r})".format(self.__class__.__name__, self.transport)

def __del__(self):
"""Ensure object store is closed when garbage collected."""
if self._pack_cache:
import warnings

warnings.warn(
f"unclosed packs in {self!r}",
ResourceWarning,
stacklevel=2,
source=self,
)
self.close()

@property
def alternates(self):
if self._alternates is not None:
Expand Down
Loading