Skip to content

[iOS] Ensure all tab removal actions add tabs to recently closed list#34220

Merged
kylehickinson merged 1 commit intomasterfrom
ios-tabgrid-recently-closed-fix
Feb 26, 2026
Merged

[iOS] Ensure all tab removal actions add tabs to recently closed list#34220
kylehickinson merged 1 commit intomasterfrom
ios-tabgrid-recently-closed-fix

Conversation

@kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 26, 2026

This fixes tabs removed by multi-select and "Close Other Tabs" not being added to the recently closed tabs list

Resolves brave/brave-browser#53157

Test

Multi-select

  • Open multiple tabs
  • Long press any tab and choose "Select Tab", select another tab and then choose "Close Tabs" in the bottom toolbar to close all selected tabs
  • Verify the closed tabs are in the recently closed list

Close Other Tabs

  • Open multiple tabs
  • Long press a tab and choose "Close Other Tabs"
  • Verify all closed tabs are in the recently closed list

Close All Tabs (Regression test)

  • Open multiple tabs
  • Tap the "More" button in the bottom left corner and tap "Close All Tabs"
  • Verify all tabs are in the recently closed list

@kylehickinson kylehickinson self-assigned this Feb 26, 2026
@kylehickinson kylehickinson requested a review from a team as a code owner February 26, 2026 16:47
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin labels Feb 26, 2026
@kylehickinson kylehickinson enabled auto-merge (squash) February 26, 2026 18:15
@github-actions
Copy link
Contributor

Chromium major version is behind target branch (145.0.7632.120 vs 146.0.7680.32). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 26, 2026
This fixes tabs removed by multi-select and "Close Other Tabs" not being added to the recently closed tabs list
@kylehickinson kylehickinson force-pushed the ios-tabgrid-recently-closed-fix branch from ae180ab to c9ddbba Compare February 26, 2026 19:24
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 26, 2026
@kylehickinson kylehickinson merged commit 55b342a into master Feb 26, 2026
22 checks passed
@kylehickinson kylehickinson deleted the ios-tabgrid-recently-closed-fix branch February 26, 2026 22:50
@github-actions github-actions bot added this to the 1.89.x - Nightly milestone Feb 26, 2026
@brave-builds
Copy link
Collaborator

Released in v1.89.81

@kjozwiak
Copy link
Member

kjozwiak commented Mar 4, 2026

Verification PASSED on iPhone 11 running iOS 26.3 using the following build(s):

Brave | 1.89.100 Chromium: 146.0.7680.32 (Official Build)nightly (64-bit) 
Revision | 39c205d7d17c...
OS | iOS

Using the STR/Cases and information outlined via #34220 (comment) & brave/brave-browser#53157 (comment), ensured that the following cases worked without any issues/failures:

Test Case #1 - Multi-select

ScreenRecording_03-04-2026.14-31-21_1.MP4

Test Case #2 - Close Other Tabs

ScreenRecording_03-04-2026.14-32-51_1.MP4

Test Case #3 - Close All Tabs

ScreenRecording_03-04-2026.14-36-30_1.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin CI/skip-windows-x64 Do not run CI builds for Windows x64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recently Closed Tabs Not Populated After “Close All Other Tabs” from Tab Switcher

6 participants