[AI Chat] [Tab Focus] Use automatic model#34202
Merged
Conversation
yrliou
requested review from
bbondy,
darkdh,
fallaciousreasoning and
kylehickinson
bbondy
approved these changes
Feb 26, 2026
emerick
approved these changes
Feb 26, 2026
Contributor
|
Chromium major version is behind target branch (145.0.7632.76 vs 146.0.7680.32). Please rebase. |
github-actions
bot
added
the
chromium-version-mismatch
Use automatic model instead of manually assign Haiku/Sonnet as server side now supports triaging tab focus requests and send to Haiku/Sonnet based on premium status, same as what we currently do on client side. Replace the premium-status-based engine selection with a simpler CreateTabOrganizationEngineIfNeeded() that always uses the "chat-automatic" model key. This removes the async GetPremiumStatus callback chain and intermediate methods. Tests are also simplied as no premium status or model name checks are needed anymore.
yrliou
force-pushed
the
tab_focus_use_automatic
branch
from
1108a88 to
dc154f1
Compare
github-actions
bot
removed
the
chromium-version-mismatch
netzenbot
approved these changes
Feb 26, 2026
Collaborator
|
Released in v1.89.83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#53153
Use automatic model instead of manually assign Haiku/Sonnet as server
side now supports triaging tab focus requests and send to Haiku/Sonnet
based on premium status, same as what we currently do on client side.
Replace the premium-status-based engine selection with a simpler
CreateTabOrganizationEngineIfNeeded() that always uses the
"chat-automatic" model key. This removes the async GetPremiumStatus
callback chain and intermediate methods.
Tests are also simplified as no premium status or model name checks are
needed anymore.
Reference server PR: https://github.com/brave/aichat/pull/1230 https://github.com/brave/aichat-ops/pull/1347