[Shields UI] Add advanced view to new panel UI#34192
Merged
zenparsing merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
github-actions
bot
added
the
CI/storybook-url
Contributor
📋 Code Owners Summary6 file(s) changed, 1 with assigned owners 1 team(s) affected: Owners and Their Files
|
Collaborator
|
A Storybook has been deployed to preview UI for the latest push |
netzenbot
approved these changes
Feb 25, 2026
Contributor
|
Chromium major version is behind target branch (145.0.7632.120 vs 146.0.7680.32). Please rebase. |
github-actions
bot
added
the
chromium-version-mismatch
zenparsing
force-pushed
the
ksmith-shields-panel-new-4
branch
from
50baead to
a7a3af0
Compare
github-actions
bot
removed
the
chromium-version-mismatch
fallaciousreasoning
requested changes
Feb 26, 2026
Contributor
fallaciousreasoning
left a comment
fallaciousreasoning
left a comment
There was a problem hiding this comment.
please use the Nala components so the styles are consistent across Brave
components/brave_shields/resources/panel_new/components/advanced_settings.tsx
Outdated
Show resolved
Hide resolved
| {getString('BRAVE_SHIELDS_TRACKERS_AND_ADS_ALLOW_ALL')} | ||
| </option> | ||
| </select> | ||
| <button |
Contributor
There was a problem hiding this comment.
ditto - can we use a Nala button for this?
Contributor
There was a problem hiding this comment.
Hey, should this one have been migrated?
components/brave_shields/resources/panel_new/components/advanced_settings.tsx
Outdated
Show resolved
Hide resolved
| }} | ||
| /> | ||
| </div> | ||
| <button |
Contributor
There was a problem hiding this comment.
Hey should this have been changed?
components/brave_shields/resources/panel_new/components/advanced_settings.tsx
Outdated
Show resolved
Hide resolved
components/brave_shields/resources/panel_new/components/advanced_settings.tsx
Show resolved
Hide resolved
components/brave_shields/resources/panel_new/components/advanced_settings.tsx
Outdated
Show resolved
Hide resolved
components/brave_shields/resources/panel_new/components/advanced_settings.style.ts
Outdated
Show resolved
Hide resolved
fallaciousreasoning
approved these changes
Feb 27, 2026
zenparsing
force-pushed
the
ksmith-shields-panel-new-4
branch
from
a7a3af0 to
cacdb88
Compare
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
Collaborator
|
Released in v1.89.88 |
| {getString('BRAVE_SHIELDS_HTTPS_UPGRADE_MODE_DISABLED')} | ||
| </leo-option> | ||
| </Dropdown> | ||
| <div /> |
Contributor
There was a problem hiding this comment.
what's this empty div for?
| }} | ||
| /> | ||
| </div> | ||
| <button |
Contributor
There was a problem hiding this comment.
Hey should this have been changed?
| }} | ||
| /> | ||
| </div> | ||
| <div /> |
| {getString('BRAVE_SHIELDS_SHOW_ALL_BLOCKED_ELEMENTS')} | ||
| </button> | ||
| </div> | ||
| <div /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtask of brave/brave-browser#53111