[News] Use interned strings for fast comparisons in feed building#34191
Merged
zenparsing merged 1 commit intomasterfrom Feb 27, 2026
Merged
[News] Use interned strings for fast comparisons in feed building#34191zenparsing merged 1 commit intomasterfrom
zenparsing merged 1 commit intomasterfrom
Conversation
zenparsing
force-pushed
the
ksmith-news-perf-3
branch
from
83b9696 to
ac32adb
Compare
netzenbot
reviewed
Feb 25, 2026
zenparsing
force-pushed
the
ksmith-news-perf-3
branch
from
ac32adb to
1dcafb3
Compare
Contributor
|
Chromium major version is behind target branch (145.0.7632.120 vs 146.0.7680.32). Please rebase. |
github-actions
bot
added
the
chromium-version-mismatch
zenparsing
force-pushed
the
ksmith-news-perf-3
branch
from
1dcafb3 to
b31d212
Compare
github-actions
bot
removed
the
chromium-version-mismatch
netzenbot
reviewed
Feb 26, 2026
zenparsing
force-pushed
the
ksmith-news-perf-3
branch
from
b31d212 to
f82528d
Compare
atuchin-m
reviewed
Feb 27, 2026
zenparsing
force-pushed
the
ksmith-news-perf-3
branch
from
f82528d to
6742571
Compare
netzenbot
reviewed
Feb 27, 2026
atuchin-m
approved these changes
Feb 27, 2026
Collaborator
atuchin-m
left a comment
atuchin-m
left a comment
There was a problem hiding this comment.
LGTM with a few nits about const&:
Let's go though all local vars in the diff and add const& where it's possible.
Introduces a NameTable for interning publisher IDs and channel names, replacing string comparisons with integer comparisons during feed generation. Publisher-to-channel mappings are computed once and reused.
zenparsing
force-pushed
the
ksmith-news-perf-3
branch
from
6742571 to
7bfbd72
Compare
Collaborator
|
Released in v1.89.86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a NameTable for interning publisher IDs and channel names, replacing string comparisons with integer comparisons during feed generation. Publisher-to-channel mappings are computed once and reused.
Subtask of brave/brave-browser#48969