[nala]: Add CODEOWNERS for Nala tokens/icons

[fallaciousreasoning]

Adds nala-token-reviewers so we hopefully can reduce the number of non-Nala icons/tokens being introduced

[github-actions]

📋 Code Owners Summary

1 file(s) changed, 1 with assigned owners

1 team(s) affected: @brave/codeowners

---

Owners and Their Files

@brave/codeowners — 1 file(s)

• .github/CODEOWNERS

[SergeyZhukovsky]

I would replace

**/values/*.xml @brave/nala-token-reviewers
**/values-night/*.xml @brave/nala-token-reviewers

to target colors only. There is a values/brave_dimens.xml with diff margins etc, I don't think we pull that from nala. I don't want we block PRs waiting for nala-token-reviewers approves if we change anything inside it.

[SergeyZhukovsky]

Currently that includes dimens.xml, brave_attrs.xml, brave_styles.xml, brave_ids.xml, array.xml, channel_constants.xml, etc. Many of these have nothing to do with Nala tokens. If the intent is to catch color token additions, consider narrowing to something like:
**/values/*color*.xml @brave/nala-token-reviewers or listing specific filenames. Otherwise the team will be tagged as required reviewers on unrelated dimension/style/id changes.

[fallaciousreasoning]

Good call! I've updated this to just target brave_colors and colors 😄

[SergeyZhukovsky]

that's a very broad coverage. We have lots of different things in drawable not related to nala tokens at all. An example rounded_top_corners.xml

<?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android">
    <solid android:color="@color/card_background_solid" />

    <corners android:topLeftRadius="30dp" android:topRightRadius="30dp"/>
</shape>

Here are other examples from each category:

Shapes (backgrounds, rounded rects, etc.):

• drawable/rounded_shape.xml
• drawable/card_bg.xml
• drawable/always_on_tutorial_action_bg.xml
• drawable/brave_stats_radio_button_normal.xml
• drawable/rounded_dot_error_status.xml

Selectors (state-dependent drawables for pressed/focused/etc.):

• drawable/always_on_tab_selector.xml
• drawable/country_spinner_background.xml
• drawable/crypto_wallet_blue_button.xml
• drawable/ic_p3a_checkbox.xml
• drawable/wallet_toolbar_panel_gradient_bg.xml

Layer-lists (composited multi-layer drawables):

• drawable/default_dot.xml
• drawable/fingerprint_unlock_layer_list.xml
• drawable/selected_indicator.xml
• drawable/always_on_tab_dot.xml

[fallaciousreasoning]

Ah good call - I just assumed they were just icons - updated to just target drawable/ic_*.xml

[bbondy]

Could we consider adding a best practice to brave-core-bot since it reviews all PRs now. Or describing it to me and I can do it? I want to try to slowly get rid of CODEOWNERS in favour of that.

[bbondy]

Closing this PR since on brave-core-bot you did a PR and it was merged to cover the things you intended to check.