[Containers] Extend PageAction framework to support partitioned storage tab in location bar#34176
Merged
sangwoo108 merged 4 commits intomasterfrom Feb 27, 2026
Merged
[Containers] Extend PageAction framework to support partitioned storage tab in location bar#34176sangwoo108 merged 4 commits intomasterfrom
sangwoo108 merged 4 commits intomasterfrom
Conversation
Contributor
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
sangwoo108
force-pushed
the
sko/container-1
branch
3 times, most recently
from
30bca05 to
0ed2dd5
Compare
goodov
approved these changes
Feb 25, 2026
netzenbot
reviewed
Feb 25, 2026
chromium_src/chrome/browser/ui/views/page_action/page_action_view.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/views/page_action/page_action_controller.cc
Outdated
Show resolved
Hide resolved
simonhong
reviewed
Feb 26, 2026
patches/chrome-browser-ui-views-location_bar-icon_label_bubble_view.cc.patch
Show resolved
Hide resolved
simonhong
reviewed
Feb 26, 2026
Member
simonhong
left a comment
simonhong
left a comment
There was a problem hiding this comment.
Changes looks good. Please add test about label visibility with forced mode
patches/chrome-browser-ui-views-location_bar-icon_label_bubble_view.cc.patch
Show resolved
Hide resolved
sangwoo108
force-pushed
the
sko/container-1
branch
3 times, most recently
from
ffa8055 to
7136c7a
Compare
Collaborator
Author
Added PageActionViewTest. Thanks ;) |
netzenbot
approved these changes
Feb 26, 2026
Contributor
|
Chromium major version is behind target branch (145.0.7632.109 vs 146.0.7680.32). Please rebase. |
github-actions
bot
added
the
chromium-version-mismatch
…ation bar This commit extends the PageAction framework to support: * Override chip colors * Always show label
sangwoo108
force-pushed
the
sko/container-1
branch
from
7136c7a to
22b092b
Compare
github-actions
bot
removed
the
chromium-version-mismatch
sangwoo108
force-pushed
the
sko/container-1
branch
from
22b092b to
18fea48
Compare
Collaborator
|
Released in v1.89.83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the PageAction framework to support:
These supports are needed for changes in #33925
Part of brave/brave-browser#52828