Skip to content

Add build/commands/tsconfig.json.#34145

Merged
goodov merged 5 commits intomasterfrom
build-commands-tsconfig
Feb 26, 2026
Merged

Add build/commands/tsconfig.json.#34145
goodov merged 5 commits intomasterfrom
build-commands-tsconfig

Conversation

@goodov
Copy link
Member

@goodov goodov commented Feb 24, 2026

Add tsconfig.json with recommended flags to run .ts natively via Node (see [1]).
Fix simple type issues and disable type checking in other files to fix them separately.

The current module system is set explicitly to CommonJS via local build/commands/package.json to not depend on the root package.json (Node lookups closest package.json to infer module system). Switch to ESM will be made separately.

  1. https://nodejs.org/docs/latest-v24.x/api/typescript.html

Resolves brave/brave-browser#53130

@goodov goodov added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 24, 2026
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 24, 2026
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the build-commands-tsconfig branch 3 times, most recently from 9c75c2d to 1e5fe52 Compare February 24, 2026 10:48
@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Found 2 lines longer than 80 characters (first 5 shown).

Items:

build/commands/lib/guessConfig.js, line 54, 111 chars
build/commands/lib/guessConfig.js, line 65, 144 chars

Base automatically changed from tsc-bump to master February 24, 2026 18:21
@goodov goodov force-pushed the build-commands-tsconfig branch from 1e5fe52 to 9d8cb41 Compare February 25, 2026 09:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

@goodov goodov force-pushed the build-commands-tsconfig branch from 9d8cb41 to c48c3c8 Compare February 25, 2026 11:03
@goodov goodov marked this pull request as ready for review February 25, 2026 12:24
@goodov goodov requested review from a team as code owners February 25, 2026 12:24
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to be making progress on this!

@goodov goodov merged commit b76e54e into master Feb 26, 2026
23 checks passed
@goodov goodov deleted the build-commands-tsconfig branch February 26, 2026 07:37
@github-actions github-actions bot added this to the 1.89.x - Nightly milestone Feb 26, 2026
@brave-builds
Copy link
Collaborator

Released in v1.89.78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type checks to build/commands

4 participants