some improvements

[fogti]

I looked through this code base (mostly because I find the ideas from the paper really cool), and noticed that the code often uses patterns which are already implemented in a nicer (and faster) form in the standard library, mostly iterator stuff...

[fogti]

this is only necessary in order to use array deconstruction iterators

[fogti]

benchmarks:

Setting up DB for benchmarking. This might take a while...
Setup complete, starting benchmarks
Starting client query benchmarks
Benchmarking lwe/create client query params, lwe_dim: 1572, m: 65536, w: 820: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.8s, or reduce sample count to 50.
lwe/create client query params, lwe_dim: 1572, m: 65536, w: 820                                                                            
                        time:   [95.321 ms 96.663 ms 98.128 ms]
                        change: [-15.754% -13.531% -11.196%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild
lwe/client query prepare, lwe_dim: 1572, m: 65536, w: 820                                                                             
                        time:   [15.587 µs 15.623 µs 15.663 µs]
                        change: [-54.062% -53.320% -52.572%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 20 outliers among 100 measurements (20.00%)
  7 (7.00%) high mild
  13 (13.00%) high severe
lwe/server response compute, lwe_dim: 1572, m: 65536, w: 820                                                                            
                        time:   [30.970 ms 31.122 ms 31.290 ms]
                        change: [-8.2067% -7.2462% -6.3148%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 16 outliers among 100 measurements (16.00%)
  4 (4.00%) high mild
  12 (12.00%) high severe
lwe/client parse server response, lwe_dim: 1572, m: 65536, w: 820                                                                            
                        time:   [200.61 µs 202.21 µs 203.84 µs]
                        change: [-56.390% -55.998% -55.592%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  6 (6.00%) high mild
  2 (2.00%) high severe
Finished client query benchmarks
lwe/derive LHS from seed, lwe_dim: 1572, m: 65536, w: 820                                                                            
                        time:   [540.86 ms 546.68 ms 549.88 ms]
                        change: [-5.0954% -4.0041% -2.8930%] (p = 0.00 < 0.05)
                        Performance has improved.
Starting DB generation benchmarks
Benchmarking lwe/generate db and params, m: 65536, w: 820: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 600.0s. You may wish to increase target time to 687.0s.
lwe/generate db and params, m: 65536, w: 820                                                                          
                        time:   [69.856 s 71.172 s 72.805 s]
                        change: [-20.473% -17.194% -13.558%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
Finished DB generation benchmarks

[claucece]

Thank you for this!I added some of this to #14 ;)