fix: replace removed embedWindow with correct vedo backend instructions#437
Merged
IgorTatarnikov merged 5 commits intobrainglobe:mainfrom Mar 13, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
Hey @alessandrofelder @adamltyson, please review when you get a chance! Removes all references to the defunct vedo.embedWindow and replaces the error message with accurate guidance, verified directly against vedo 2026.6.1 source. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 27 27
Lines 1239 1239
=======================================
Hits 1073 1073
Misses 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
IgorTatarnikov
left a comment
IgorTatarnikov
left a comment
There was a problem hiding this comment.
Hi @AdityaGupta716, this looks great! Just a small comment regarding formatting.
Co-authored-by: Igor Tatarnikov <61896994+IgorTatarnikov@users.noreply.github.com>
Contributor
Author
|
@IgorTatarnikov commited the change thanks |
IgorTatarnikov
approved these changes
Mar 13, 2026
Member
IgorTatarnikov
left a comment
IgorTatarnikov
left a comment
There was a problem hiding this comment.
LGMT 🎉 thanks @AdityaGupta716
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the misleading error message in
brainrender/_jupyter.pythatreferenced
vedo.embedWindow, which has been removed from the vedo library.Why is this needed?
Closes #413
Changes
embedWindowAPInot_on_jupyterdecorator to directusers to set
vedo.settings.default_backend = 'k3d'for notebook userunning in a standard Python script or terminal for full functionality
How was this tested?
"k3d"confirmed as the correct notebook backend in vedo settingsIs this a breaking change?
No
Does this require a documentation update?
No