Add unit tests for check_values() and get_ax_idx()#128
Open
BhoomikaC15 wants to merge 2 commits intobrainglobe:mainfrom
Open
Add unit tests for check_values() and get_ax_idx()#128BhoomikaC15 wants to merge 2 commits intobrainglobe:mainfrom
BhoomikaC15 wants to merge 2 commits intobrainglobe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
This PR increases the test coverage for functions that currently don't have any dedicated tests:
check_values()inheatmaps.pyandget_ax_idx()inslicer.py.What does this PR do?
Adds total of 21 new tests in two new test files:
test_check_values.py— 15 tests covering valid inputs (single/multiple regions, integers, floats, zeros), NaN handling (all NaN, partial NaN), and invalid inputs (None, strings, lists, unknown regions)test_get_ax_idx.py— 6 tests covering valid orientations (frontal, sagittal, horizontal), case sensitivity, and invalid/empty valuesAlso uses a mock atlas fixture so no atlas download or network access needed.
References
Relates to issue #23
How has this PR been tested?
All 21 tests pass locally with
pytest tests/test_unit/ -von Python 3.13.5 / Windows.Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
No. This PR only adds new test files.
Does this PR require an update to the documentation?
No
Checklist: