Issue #582: Add simplified badge colors #669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Longtime fan of this project and excited to contribute! :)
This PR looks to address this issue: #582
I've added support for named colors in
sccbadges. This lets end users use human readable color names instead of only hex values, and preserves backwards compatibility.WHAT CHANGED:
namedColorsmap that covers the following:resolveColor()helperparseBadgeSettings()to useresolveColor()instead of the old hex-only regex validationWith the above, users can now write:
instead of
Hex codes work exactly as before so this is fully backwards compatible.
Let me know if you have any feedback and I can implement it!