feat(deps): BREAKING CHANGE Resolve serialize-javascript to ^7.0.3 and drop Node 18#4469
feat(deps): BREAKING CHANGE Resolve serialize-javascript to ^7.0.3 and drop Node 18#4469
Conversation
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge Queue StatusRule:
This pull request spent 4 hours 4 minutes 49 seconds in the queue, with no time running CI. ReasonThe pull request #4469 has been manually updated HintIf you want to requeue this pull request, you can post a |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 361: The forced resolutions entry pinning "serialize-javascript" to
"^7.0.3" is incompatible with Node 18; either relax the resolution to a v6.x
range compatible with Node 18 (e.g., "serialize-javascript": "^6.0.0") or update
the package.json engines.node field to remove Node 18 support (e.g., bump to
">=20.x || ^22.x"); update the "resolutions" entry that references
serialize-javascript or the "engines.node" value in package.json accordingly and
ensure any lockfile is regenerated so the chosen version is installed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 51a794e8-47c2-4d86-bdfc-22bc738bd958
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json
BREAKING CHANGE: Drop support for Node 18
b03b5eb
b2aea4c to
b03b5eb
Compare
Summary by CodeRabbit