Closed
Conversation
Member
|
Probably useful to have an input option for the tolerance on this to automatically fail if it's too large. The plotting should also be user controllable, rather than unconditional |
# Conflicts: # zoidberg/examples/screwpinch.py
GHA sets it to a value that is not valid in the container
less indention, as the short branch comes first
n is for toroidal and m for poloidal
Allows to create grids based on EMC3 grids.
…idberg into more-6-check-flux
Collaborator
Author
|
I have removed the plotting, and only print the error. I do not see how we manage to get this reliably small enough without some fudging, which I think is probably better done in BOUT++, to ensure things are consistent. Maybe we should completely remove the check, i.e. not add this PR. Other things in this PR:
@ZedThree I can separate them, if you think that makes sense. |
Member
|
Yes please, smaller PRs are just easier to look over :) |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check that
B*J/sqrt(g_22)stays constant along the traced flux tube.