Add selectors and boundary flow source diagnostics#27
Draft
mikekryjak wants to merge 4 commits intomainfrom
Draft
Add selectors and boundary flow source diagnostics#27mikekryjak wants to merge 4 commits intomainfrom
mikekryjak wants to merge 4 commits intomainfrom
Conversation
Represents flows through boundaries as sources. Currently only implemented for SOL and PFR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2D particle and energy balances are challenging. One of the ways this is unwieldy is that the boundary flows must be calculated from flow diagnostics and care must be kept to select the right cells (e.g. the perpendicular flows are on the
xlowside, which means you need to select the final domain cell at the PFR, but the guard cell at the SOL).This PFR adds new diagnostics where the boundary flows are represented as sources in the final domain cells, making it a lot easier to tally up where things are going.
It also adds a few new selectors, adds the toroidal cell length variable and renames
dltodpol.