bottle-row: Set can-target and can-focus to false#3808
Merged
TheEvilSkeleton merged 1 commit intobottlesdevs:mainfrom Mar 15, 2025
Merged
Conversation
TheEvilSkeleton
force-pushed
the
disable-target-in-radio-button
branch
from
7a233ed to
32ed442
Compare
The GtkListBox::row-activated signal only emits when a row is activated, not the child widget. This means, the check button wouldn't trigger the emission of the signal, thereby not updating the NewBottleDialog:selected-environment property. Fixes bottlesdevs#3740
TheEvilSkeleton
force-pushed
the
disable-target-in-radio-button
branch
from
32ed442 to
ced72cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GtkListBox::row-activated signal only emits when a row is activated, not the child widget. This means, the check button wouldn't trigger the emission of the signal, thereby not updating the NewBottleDialog:selected-environment property.
Fixes #3740