Skip to content

fix: tighten URL validation and reject control characters in modeled-types - #150

Draft
jmt-lab wants to merge 1 commit into
bottlerocket-os:developfrom
jmt-lab:fix/url
Draft

fix: tighten URL validation and reject control characters in modeled-types#150
jmt-lab wants to merge 1 commit into
bottlerocket-os:developfrom
jmt-lab:fix/url

Conversation

@jmt-lab

@jmt-lab jmt-lab commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description of changes:

  • Adds tighter URL validation to avoid malformed URLs from going through.
  • Adds a helper for rejecting control characters and adds use of it where applicable
  • Migrates OCIImageRef's to a separate URL type due to OCIImageRef's url's generally not having a protocol prefix and resolving via ctr,krane,docker logistics.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmt-lab
jmt-lab force-pushed the fix/url branch 2 times, most recently from 10b9e3b to 22ec8c9 Compare September 3, 2026 20:16
@jmt-lab
jmt-lab marked this pull request as draft September 3, 2026 21:09
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant