packages: add nvidia-dra-driver-gpu - #1035
Open
maherthomsi wants to merge 2 commits into
Open
Conversation
arnaldo2792
reviewed
Sep 11, 2026
maherthomsi
force-pushed
the
dra-changes
branch
from
September 11, 2026 06:59
41e32c2 to
1e8bb1e
Compare
Contributor
Author
|
Added settings-sdk changes to this PR |
maherthomsi
force-pushed
the
dra-changes
branch
4 times, most recently
from
September 11, 2026 22:06
63c65b5 to
5dc5941
Compare
vigh-m
reviewed
Sep 11, 2026
vigh-m
reviewed
Sep 11, 2026
maherthomsi
force-pushed
the
dra-changes
branch
from
September 11, 2026 23:12
5dc5941 to
fb76dcc
Compare
Contributor
Author
|
Addresses review feedback on the nvidia-dra-driver-gpu package:
|
arnaldo2792
reviewed
Sep 11, 2026
Comment on lines
+30
to
+33
| # --image-name is only used to render MPS control-daemon pods; MPS is alpha and | ||
| # disabled by default, and an empty string satisfies the required flag. | ||
| # --healthcheck-port -1 disables the gRPC healthcheck service: any negative | ||
| # value short-circuits startHealthcheck before it creates a listener. |
Contributor
There was a problem hiding this comment.
nit: they should go on top of the flags they reference.
| @@ -0,0 +1,18 @@ | |||
| [Unit] | |||
Contributor
There was a problem hiding this comment.
You should mimic what the kubelet-device-plugin does:
- Provide a unit that just works - with the drop-in for the host name
- Provide an override that runs
truewhen disabled - And in the same template, provide the "enabled" case and run the unit
maherthomsi
force-pushed
the
dra-changes
branch
from
September 11, 2026 23:49
fb76dcc to
93457dd
Compare
Add the nvidia-dra-driver-gpu package, which builds the NVIDIA GPU DRA driver (gpu-kubelet-plugin) and installs it as a host systemd service. Include it in the bottlerocket-core-kit workspace and kit manifest. Signed-off-by: Maher Homsi <maherhom@amazon.com>
Signed-off-by: Maher Homsi <maherhom@amazon.com>
maherthomsi
force-pushed
the
dra-changes
branch
from
September 12, 2026 01:02
93457dd to
1919b69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds the nvidia-dra-driver-gpu package, which builds the NVIDIA GPU DRA driver (gpu-kubelet-plugin) and installs it as a host systemd service. The package is added to the bottlerocket-core-kit workspace and included in the kit manifest so it is available to consuming variants.
Bump settings sdk for this change to include bottlerocket-os/bottlerocket-settings-sdk#148
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.