fix(parser): handle StreamingChecksumBody in generic error response detection#3680
Open
armorbreak001 wants to merge 1 commit intoboto:developfrom
Open
fix(parser): handle StreamingChecksumBody in generic error response detection#3680armorbreak001 wants to merge 1 commit intoboto:developfrom
armorbreak001 wants to merge 1 commit intoboto:developfrom
Conversation
…etection When response checksums are enabled, response body is wrapped in StreamingChecksumBody which lacks a strip() method. Read the body first before calling strip() to avoid AttributeError. Fixes #4754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When response checksums are enabled (e.g.
FlexibleChecksumStrategy), the response body is wrapped in aStreamingChecksumBodyobject. This object extendsStreamingBodyand does not have astrip()method.```_is_generic_error_response()`` calls
response['body'].strip()unconditionally, which raises:Changes
Read the body via
.read()first when it lacks astrip()method before calling.strip(). This is safe for error responses (status >= 500) where the body is only needed to detect generic HTML error pages.Fixes boto/boto3#4754
Related: boto/boto3#4765