🐛 Change the check way to check if the user have right to change some property#3534
Closed
macintoshplus wants to merge 1 commit intobolt:5.2from
Closed
🐛 Change the check way to check if the user have right to change some property#3534macintoshplus wants to merge 1 commit intobolt:5.2from
macintoshplus wants to merge 1 commit intobolt:5.2from
Conversation
Member
|
This is something I want to look into a bit deeper, so that can take some time. |
Contributor
Author
|
Ping me if you want more explanation for this change. |
macintoshplus
force-pushed
the
fix_property_change_check
branch
from
ef33033 to
1061e17
Compare
Member
|
I'm going to close this, as the access denied error is the error that should be thrown. Reverting changes will only hide grants issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes one of the Cypress tests for users with the ROLE_EDITOR role.
If the user does not have permission to change the properties, the original values are reapplied.
With the old behavior, a user with the ROLE_EDITOR role (john_editor in the Cypress tests) cannot add or modify content.