Skip to content

fix(vm/remaining: convert panics to EngineError::Panic using js_expect#5267

Draft
KaustubhOG wants to merge 1 commit intoboa-dev:mainfrom
KaustubhOG:fix/vm-remaining
Draft

fix(vm/remaining: convert panics to EngineError::Panic using js_expect#5267
KaustubhOG wants to merge 1 commit intoboa-dev:mainfrom
KaustubhOG:fix/vm-remaining

Conversation

@KaustubhOG
Copy link
Copy Markdown
Contributor

Part of #3241.

Converts all convertible .expect() panics to .js_expect()? in:

  • opcode/get/property.rs (2)
  • opcode/get/name.rs (2)
  • opcode/get/private.rs (1)
  • opcode/binary_ops/mod.rs (1)
  • opcode/copy/mod.rs (2)
  • opcode/set/private.rs (2)
  • opcode/call/mod.rs (6)
  • opcode/iteration/iterator.rs (4)

Total: 20 panics converted.

@github-actions github-actions bot added C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers labels Mar 27, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 27, 2026
@github-actions
Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,732 50,732 0
Ignored 1,426 1,426 0
Failed 805 805 0
Panics 0 0 0
Conformance 95.79% 95.79% 0.00%

Tested main commit: 2437b6704c4315f6ec8f0766bf229fba23e0e61e
Tested PR commit: c5045fecaaa1641f60dd33f1b23703a2cbaccbe4
Compare commits: 2437b67...c5045fe

@KaustubhOG
Copy link
Copy Markdown
Contributor Author

Note: this PR along with #5228 and #5232 covers the majority of convertible panics in vm/.the orginal idea was A #5228 and #5232 will cover all the panics in vm/ but in #5232 i made some new changes so after that #5267 cames in picture with handling all remaining panics . (get/, binary_ops/, copy/, set/private.rs, call/mod.rs, iteration/iterator.rs) . Once all three are merged, all convertible panics in vm/ will be fully resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.79%. Comparing base (6ddc2b4) to head (c5045fe).
⚠️ Report is 919 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/vm/opcode/get/name.rs 0.00% 5 Missing ⚠️
core/engine/src/vm/opcode/copy/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5267       +/-   ##
===========================================
+ Coverage   47.24%   59.79%   +12.55%     
===========================================
  Files         476      589      +113     
  Lines       46892    63407    +16515     
===========================================
+ Hits        22154    37915    +15761     
- Misses      24738    25492      +754     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant