Skip to content

Redesign CLI executor to avoid spin looping when idle #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedel1043 merged 10 commits into from
Mar 27, 2026
Merged

Redesign CLI executor to avoid spin looping when idle #4994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f1691c8
Rework CLI executor to not use 100% CPU when idle
jedel1043 Mar 10, 2026
26ffcfa
Use !Send and !Sync listeners
jedel1043 Mar 11, 2026
af89f68
Properly cleanup cancelled timeouts
jedel1043 Mar 11, 2026
ef22f1f
Fix timeout jobs
jedel1043 Mar 12, 2026
fbf2312
Merge remote-tracking branch 'upstream/main' into cli-cpu-usage
jedel1043 Mar 17, 2026
6adab53
Rename OnceFlag to CancellationToken
jedel1043 Mar 19, 2026
c1bd963
Merge remote-tracking branch 'upstream/main' into cli-cpu-usage
jedel1043 Mar 19, 2026
5ed2f6d
Panic on debug if setting the callback of a used cancellation token
jedel1043 Mar 19, 2026
3302402
Simplify set_callback
jedel1043 Mar 19, 2026
b615a08
Merge branch 'main' into cli-cpu-usage
jedel1043 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ futures-channel = "0.3.32"
aligned-vec = "0.6.4"
temp-env = "0.3.6"
strum = { version = "0.28", features = ["derive"] }
unsend = { version = "0.2.1", default-features = false }
husky-rs = "0.3.2"
async-channel = "2.5.0"

Expand Down
3 changes: 2 additions & 1 deletion cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ dhat = { workspace = true, optional = true }
color-eyre.workspace = true
cow-utils.workspace = true
futures-concurrency.workspace = true
futures-lite.workspace = true
smol.workspace = true
unsend = { workspace = true, features = ["alloc"] }
async-channel.workspace = true
rustls.workspace = true

Expand Down
Loading
Loading